Fix error types #89
Merged
Fix error types #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idky137
added
bug
This was referenced Nov 2, 2024
Merged
Merged
Merged
Oscar-Pepper
requested changes
Nov 6, 2024
zaino-serve/src/rpc/service.rs
Outdated
| { | ||
| break; | ||
| if height > chain_height { | ||
| let _ = channel_tx |
There was a problem hiding this comment.
sometimes the compliler asks to put "let _ = " but i think this is bad advice. sometimes its useful to use this to keep something in scope but i still prefer "let _unused_name_of_thing =" in stead of just underscore for that. in this case i believe you need to actually handle your result with a match and error handling or atleast an expect if it cant fail
There was a problem hiding this comment.
change added in 724ef3f
zaino-serve/src/rpc/service.rs
Outdated
| { | ||
| break; | ||
| if height > chain_height { | ||
| let _ = channel_tx |
There was a problem hiding this comment.
see comment above about "let _ ="
There was a problem hiding this comment.
change added in 724ef3f
This was referenced Nov 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the errors returned for get_block, get_block_range, get_nullifiers, get_nullifiers_range RPCs.