Skip to content

Commit

Permalink
Remove @@ nonFlaky(20) as we get connection timeouts
Browse files Browse the repository at this point in the history
```scala
    - Https Client request - From Trust Store / Client / should throw DecoderException for handshake failure - 36 s 514 ms
      ✗ ConnectTimeoutException was not List(DecoderException, PrematureChannelClosureException)
      <CODE>
      hasField = "ConnectTimeoutException"
      fails = io.netty.channel.ConnectTimeoutException: connection timed out after 30000 ms: untrusted-root.badssl.com/104.154.89.105:443
      input = Failure(
        cause = Fail(
          value = io.netty.channel.ConnectTimeoutException: connection timed out after 30000 ms: untrusted-root.badssl.com/104.154.89.105:443,
          trace = StackTrace(
            fiberId = Composite(
              left = Runtime(
                id = 208992,
                startTimeMillis = 1737881442230,
                location = "zio.http.ClientHttpsSpecBase.tests.actual(ClientHttpsSpec.scala:66)"
              ),
              right = Runtime(
                id = 208991,
                startTimeMillis = 1737881442230,
                location = "zio.http.ClientHttpsSpecBase.tests(ClientHttpsSpec.scala:65)"
              )
            ),
            stackTrace = Chunk("zio.http.ClientHttpsSpecBase.tests.actual(ClientHttpsSpec.scala:66)", "zio.http.ClientHttpsSpecBase.tests.actual(ClientHttpsSpec.scala:66)", "zio.http.ClientHttpsSpecBase.tests(ClientHttpsSpec.scala:67)", "zio.http.ClientHttpsSpecBase.tests(ClientHttpsSpec.scala:65)")
          )
        )
      )
      at /home/runner/work/zio-http/zio-http/zio-http/jvm/src/test/scala/zio/http/ClientHttpsSpec.scala:67
```

See https://github.com/zio/zio-http/actions/runs/12973059540/job/36181246408?pr=3279
  • Loading branch information
guizmaii committed Jan 26, 2025
1 parent eeceb6e commit 647386a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion zio-http/jvm/src/test/scala/zio/http/ClientHttpsSpec.scala
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ abstract class ClientHttpsSpecBase extends ZIOHttpSpec {
),
),
)
} @@ nonFlaky(20),
},
)
.provideShared(
ZLayer.succeed(ZClient.Config.default.ssl(sslConfig)),
Expand Down

2 comments on commit 647386a

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 : Performance Benchmarks (SimpleEffectBenchmarkServer)

concurrency: 256
requests/sec: 369897

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 : Performance Benchmarks (PlainTextBenchmarkServer)

concurrency: 256
requests/sec: 369485

Please sign in to comment.