Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Zitadel provider fails to upload images using resource "zitadel_label_policy" #152 #153

Closed
wants to merge 1 commit into from

Conversation

akinsella-socrate
Copy link

This pull request refers to the issue #152 (Zitadel provider fails to upload images using resource "zitadel_label_policy")

Definition of Ready

  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story ( Zitadel provider fails to upload images using resource "zitadel_label_policy" #152 )
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • All non-functional requirements are met
  • The generic lifecycle acceptance test passes for affected resources.
  • Examples are up-to-date and meaningful. The provider version is incremented.
  • Docs are generated.
  • Code is generated where possible.

@stebenz stebenz enabled auto-merge January 31, 2024 15:29
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a81d553) 63.20% compared to head (7cd437f) 63.20%.
Report is 13 commits behind head on main.

Files Patch % Lines
zitadel/helper/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   63.20%   63.20%           
=======================================
  Files         156      156           
  Lines       12609    12609           
=======================================
  Hits         7969     7969           
  Misses       3379     3379           
  Partials     1261     1261           
Flag Coverage Δ
acceptance-tests 63.20% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stebenz
Copy link
Contributor

stebenz commented Jan 31, 2024

@akinsella-socrate could you please merge back the main branch?

@hifabienne
Copy link
Member

@akinsella-socrate Can you please merge the main into your branch? Or give us the rights to do that?

@hifabienne
Copy link
Member

Hei @akinsella-socrate
We will close the pr by the end of march, if we do not get an updated version.
You can always send a new pr, but we are not able to merge it at the moment as we can't merge the main ourselfv into your branch.

@eliobischof eliobischof mentioned this pull request Mar 14, 2024
12 tasks
@eliobischof
Copy link
Member

Closing in favor of #166

auto-merge was automatically disabled March 14, 2024 10:42

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants