Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update generator to generate User client v2 #381

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

TWinsnes
Copy link
Contributor

@TWinsnes TWinsnes commented Sep 17, 2024

This PR generates the missing V2 of the user client as mentioned in #373

v2beta is deprecated and is throwing warnings when using the client. This adds the GA v2 client without breaking the applications that are already on v2beta

Biggest change other than adding the generated code is to add a methods to pkg/client/client.go to support the new client versions

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label Sep 17, 2024
@hifabienne hifabienne requested a review from livio-a September 19, 2024 09:37
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 6994 lines in your changes missing coverage. Please review.

Project coverage is 0.05%. Comparing base (0ebcb4b) to head (b09083d).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
.../client/zitadel/settings/v2/settings_service.pb.go 0.00% 801 Missing ⚠️
...kg/client/zitadel/session/v2/session_service.pb.go 0.00% 713 Missing ⚠️
pkg/client/zitadel/user/v2/query.pb.go 0.00% 705 Missing ⚠️
pkg/client/zitadel/session/v2/session.pb.go 0.00% 614 Missing ⚠️
pkg/client/zitadel/user/v2/idp.pb.go 0.00% 356 Missing ⚠️
pkg/client/zitadel/session/v2/challenge.pb.go 0.00% 339 Missing ⚠️
pkg/client/zitadel/object/v2/object.pb.go 0.00% 332 Missing ⚠️
pkg/client/zitadel/org/v2/org_service.pb.go 0.00% 280 Missing ⚠️
pkg/client/zitadel/user/v2/password.pb.go 0.00% 246 Missing ⚠️
pkg/client/zitadel/org/v2/query.pb.go 0.00% 242 Missing ⚠️
... and 24 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #381      +/-   ##
========================================
- Coverage   0.05%   0.05%   -0.01%     
========================================
  Files         91     127      +36     
  Lines      81311   92966   +11655     
========================================
  Hits          47      47              
- Misses     81261   92916   +11655     
  Partials       3       3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@livio-a livio-a changed the title Updated generator to generate User client v2 feat: update generator to generate User client v2 Sep 24, 2024
@livio-a livio-a merged commit 0e123ac into zitadel:main Sep 24, 2024
6 of 7 checks passed
@livio-a
Copy link
Member

livio-a commented Sep 24, 2024

Hi @TWinsnes

Thanks for adding this!
If you'd like some small gift, please reach out to [email protected]

Copy link
Contributor

🎉 This PR is included in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os-contribution This is a contribution from our open-source community released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants