Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:绩点计算器的功能 #176

Merged
merged 10 commits into from
Jan 20, 2025

Conversation

luolananDR
Copy link
Contributor

No description provided.

@j10ccc j10ccc changed the base branch from master to release/feat/score-calculator January 20, 2025 08:40
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件有必要吗,不是有一个 collapse panel 了吗?

import "./index.scss";

type PropsType = {
arrow?: "right" | "down";
selected?: boolean;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一定要改 list 组件吗?带选择逻辑的不能单独弄一个组件给成绩用?选择框和文案都放到 slot 里面。list 这个基础组件,组件名字面意思,没必要耦合选择逻辑

<view
v-if="props.year!='全'"
class="picker"
:v-if="props.selectflag === 1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

给 v-if 加上 bind 语法糖是啥意思?

];
const selector = reactive(selectorArr[props.selectflag]);

/** e.g. 2022 上 期中 */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这行注释放在这里是啥意思?

<view class="iconfont icon-paixu" @tap="handleSort" />
</w-button>
</view>
<view />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是干啥的?

@j10ccc j10ccc marked this pull request as ready for review January 20, 2025 09:34
@xixiIBN5100 xixiIBN5100 merged commit fcd58ef into zjutjh:release/feat/score-calculator Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants