Convenience rollup of PR 21 + PR 22 #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/squeeze.rs
# Conflicts: # src/squeeze.rs
# Conflicts: # src/squeeze.rs
|
I appreciate you trying to make it easier to merge these two related PRs, but I find it easier to review them one at a time. I'm closing this, hope you don't mind! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains #21, #22 and the changes necessary to resolve conflicts between them. It's from the branch I used for testing in https://app.circleci.com/pipelines/github/Pr0methean/OcHd-RustBuild/850/workflows/d05c2900-4e16-41a7-873a-d13108ee92a7/jobs/6475, which compressed the PNGs to a total of just 282,391 bytes in 52m7s (compare to https://app.circleci.com/pipelines/github/Pr0methean/OcHd-RustBuild/848/workflows/83c39815-4d2b-40c3-a719-233b6a259995/jobs/6462 which produced 282,243 bytes but took 53m9s).