Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Sync of feature/v3/jcl on v3.x/staging #4107

Open
wants to merge 298 commits into
base: v3.x/staging
Choose a base branch
from

Conversation

MarkAckert
Copy link
Member

Test PR so we can compare the changes in this PR against the existing feature/v3/jcl which is based on v2.x/staging.

When these changes look correct, we'll rebase the feature/v3/jcl branch.

Martin-Zeithaml and others added 30 commits February 21, 2024 09:14
Signed-off-by: Martin Zeithaml <[email protected]>
* Use the zos function

Signed-off-by: Martin Zeithaml <[email protected]>

* CCSID only for platform=zos

Signed-off-by: Martin Zeithaml <[email protected]>

* Update type declaration file

Signed-off-by: Martin Zeithaml <[email protected]>

---------

Signed-off-by: Martin Zeithaml <[email protected]>
Co-authored-by: Mark Ackert <[email protected]>
* TSS: Detect zOSMF Root CA

Signed-off-by: Martin Zeithaml <[email protected]>

* Parameters updated

Signed-off-by: Martin Zeithaml <[email protected]>

* Minor text change

Signed-off-by: Martin Zeithaml <[email protected]>

---------

Signed-off-by: Martin Zeithaml <[email protected]>
Signed-off-by: Martin Zeithaml <[email protected]>
Co-authored-by: Mark Ackert <[email protected]>
…eded on newer zos. fix vsam existence check with new function.

Signed-off-by: 1000TurquoisePogs <[email protected]>
…to 'ZWEIMVS' JCL. Uncomment defaults in example-zowe.yaml for ZWEGENER success. Improve templates of ZWEKRING, ZWENOKYR, ZWENOSEC. Add zos-jes from PR 3135 for use in generate. Add dry-run mode to init mvs.

Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
… that see it is missing. make clear start and end to jcl output

Signed-off-by: 1000TurquoisePogs <[email protected]>
…se temp file. add zosmf keyring info to example-zowe

Signed-off-by: 1000TurquoisePogs <[email protected]>
… and having wait for job wait properly

Signed-off-by: 1000TurquoisePogs <[email protected]>
Copy link

github-actions bot commented Jan 27, 2025

build 6855 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12986134535

Copy link

github-actions bot commented Jan 27, 2025

Test workflow 6021 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4107/zowe-3.1.0-pr-4107-6855-20250127094846.pax
Running on machine: zzow11
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12986237266

@Martin-Zeithaml
Copy link
Contributor

Martin-Zeithaml commented Jan 28, 2025

Improvements needed:

Messages

The message ZWEL0319E seems to be overloaded:

ZWEL0319E||NodeJS required but not found. Errors such as ZWEL0157E may occur as a result. The value 'node.home' in the Zowe YAML is not correct. 
ZWEL0319E|319|zowe.setup.dataset.jcllib does not exist, cannot run. Run 'zwe init', 'zwe init generate', or submit JCL ${prefix}.SZWESAMP(ZWEGENER) before running this command.
ZWEL0319E|319|Configuration stored in PARMLIB must use member name ZWEYAML when using generate action.

Update of parmlib

zwe init updates a members and then it fails:

zwe init -c 'ZOWE.PARM(HELLO)' --update-config
Writing temp file for PARMLIB update. Command= cp -v "/tmp/.zweenv-7470/zwe-parmlib-3194" "//'ZOWE.PARM(HELLO)'

ERROR: ZWEL0319E Configuration stored in PARMLIB must use member name ZWEYAML when using generate action.

It should fail before any update.

Parmlib

zwe init --config 'PARMLIB(ZOWE.PR#4107.PARMLIB(A))' will cause a problem here as the config path is split based on words FILE|PARMLIB. I am afraid, the word PARMLIB is used for, ehm, parmlib very often. This must be rewritten.

Signed-off-by: Martin Zeithaml <[email protected]>
Copy link

github-actions bot commented Jan 28, 2025

build 6862 FAILED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13007956985

Signed-off-by: Martin Zeithaml <[email protected]>
Copy link

github-actions bot commented Jan 28, 2025

build 6863 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13008398375

Copy link

github-actions bot commented Jan 28, 2025

Test workflow 6029 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4107/zowe-3.1.0-pr-4107-6863-20250128103229.pax
Running on machine: zzow10
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13008519072

@MarkAckert
Copy link
Member Author

@Martin-Zeithaml do you think this is ready to merge into #3718? After merge, we can change the head on that PR to v3.x/staging

@Martin-Zeithaml
Copy link
Contributor

@Martin-Zeithaml do you think this is ready to merge into #3718? After merge, we can change the head on that PR to v3.x/staging

I thought this will be merged (some day) into v3.x/staging and the #3718 will be just deleted.
I am testing this and making changes here only. There are some new problems.

@MarkAckert
Copy link
Member Author

We should close out #3718 then to avoid confusion with this PR. I can update the title and description. cc @1000TurquoisePogs does that sound OK to you?

@MarkAckert MarkAckert added the CICD_Quiet Used by automation to disable cicd comments on PRs. label Jan 29, 2025
@MarkAckert
Copy link
Member Author

@Martin-Zeithaml do you think this is ready to merge into #3718? After merge, we can change the head on that PR to v3.x/staging

I thought this will be merged (some day) into v3.x/staging and the #3718 will be just deleted. I am testing this and making changes here only. There are some new problems.

I took a stab at problems 2 and 3, without a complete test suite pointed at it. I added a new message ZWEL0320E which may not help with overloaded or sprawling messages...

@Martin-Zeithaml
Copy link
Contributor

Apfauth

Help:

  • zowe.setup.dataset.authLoadlib is the user custom APF LOADLIB. This field is
    optional. If it's not defined, SZWEAUTH from zowe.setup.dataset.prefix data
    set will be APF authorized.
  • zowe.setup.dataset.authPluginLib is the user custom APF PLUGINLIB.
    You can install Zowe ZIS plugins into this load library.

zowe.setup.dataset.authLoadlib and zowe.setup.dataset.authPluginLib omitted in config and this is generated by ZWEGEN00:

//STDPARM DD *                                          
SH cd '/zowe/' &&                       
cd bin/utils &&                                         
export LOADLIB='CFG.ZOWE.SETUP.DATASET.AUTHLOADLIB' &&  
export LOADLOC=SMS &&                                   
export PLUGLIB='CFG.ZOWE.SETUP.DATASET.AUTHPLUGINLIB' &&
export PLUGLOC=SMS &&                                   
./opercmd.rex "SETPROG APF,ADD,DSN=$LOADLIB,$LOADLOC" &&
./opercmd.rex "SETPROG APF,ADD,DSN=$PLUGLIB,$PLUGLOC"   
//*                                                     

When trying zwe init apfauth -c ./zowe.yaml:

ERROR: Error ZWEL0157E: zowe.setup.dataset.authLoadlib is not defined in Zowe YAML configuration file.

Expectation:
If zowe.setup.dataset.authLoadlib and zowe.setup.dataset.authPluginLib omitted, the JCL will authorize only zowe.setup.dataset.prefix.SZWEAUTH.

@MarkAckert
Copy link
Member Author

I started on the Apfauth updates, testing in the other PR. More changes to come - the first commit isn't working yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD_Quiet Used by automation to disable cicd comments on PRs.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants