Don't convert certificates already in EBCDIC during init #4135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
|
build 6742 SUCCEEDED. |
|
build 6743 SUCCEEDED. |
Signed-off-by: MarkAckert <[email protected]>
|
build 6744 SUCCEEDED. |
Martin-Zeithaml
approved these changes
Jan 16, 2025
MarkAckert
temporarily deployed
to
marist-zzow09
GitHub Actions
Inactive
|
Test workflow 5942 is started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a test failure captured in external certificate verification. The
certificate initscripts were setup to always convert keytool-exported certificates from ASCII to EBCDIC, however some newer versions of keytool export the certificate in EBCDIC.This PR fixes the error where an EBCDIC cer was created and became unreadable due to conversion. If we can't recognize the certificate as EBCDIC, the conversion still happens, which matches the prior behavior.