Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validateJavaHome returns better message #4159

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

Martin-Zeithaml
Copy link
Contributor

For Java 17, the function java.validateJavaHome(); could return Java 17.0.0" 2024-01-0 (extra quote and incomplete date).

The original implementation was made for Java 8 with different output.

This fixes both cases:

  • java version "1.8.0_321"
  • java version "17.0.10" 2024-01-02

Tests:

java version "1.17.0" 2024-01-16 -> Java 17.0.10 2024-01-16 is supported.
java version "1.17.0"            -> Java 1.17.0 is supported.
java version "1.8.0_321"         -> ERROR: Java 1.8.0_321 is less than the minimum level required of Java 17.

Copy link

github-actions bot commented Jan 29, 2025

build 6872 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13032182338

Copy link

github-actions bot commented Jan 29, 2025

Test workflow 6038 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4159/zowe-3.1.0-pr-4159-6872-20250129132235.pax
Running on machine: zzow11
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13032299914

@MarkAckert MarkAckert merged commit 269f2d7 into v3.x/staging Jan 29, 2025
13 checks passed
@MarkAckert MarkAckert deleted the Martin-Zeithaml-patch-1 branch January 29, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants