Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Exclude None values from request payload in Endpoint class. #851

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

octocamocoder47
Copy link

Description
Refactored the Endpoint class to exclude parameters with None values from the request payload. This ensures cleaner API interactions and avoids unintended behavior, improving code reliability and alignment with best practices.

Fixes: #847 (#847 )

How did you test this PR?

I couldn't test PR because I don't have api keys and proper env setup to test it.

  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@pransh62390 pransh62390 force-pushed the google-calendar-integration-847-new branch 5 times, most recently from 3460d01 to cbdfa80 Compare January 16, 2025 11:55
@timabbott
Copy link
Member

@Niloth-p I assume you'll take point on reviewing this.

@pransh62390 pransh62390 force-pushed the google-calendar-integration-847-new branch from cbdfa80 to 23e79da Compare January 26, 2025 07:32
Refactored the Endpoint class to exclude parameters with None values
from the request payload. This ensures cleaner API interactions and
avoids unintended behavior, improving code reliability and aligning
with best practices.

Fixes zulip#847
@pransh62390 pransh62390 force-pushed the google-calendar-integration-847-new branch from 23e79da to beae5ab Compare January 26, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Google Calendar integration
4 participants