Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msglist: Catch invalid-URL error on link long-press #5855

Merged
merged 2 commits into from
Apr 25, 2024
Merged

msglist: Catch invalid-URL error on link long-press #5855

merged 2 commits into from
Apr 25, 2024

Conversation

chrisbobbe
Copy link
Contributor

Fixes: #5854

@chrisbobbe chrisbobbe requested a review from gnprice April 9, 2024 18:34
@chrisbobbe
Copy link
Contributor Author

@chrisbobbe
Copy link
Contributor Author

It's possible that a confirmation dialog isn't the right solution, but my thinking was:

  • People probably don't want to copy a "link" that browsers can't make sense of.
  • People will want feedback telling them that the usual long-press behavior (copy a valid link) didn't happen.

@gnprice
Copy link
Member

gnprice commented Apr 25, 2024

Sure, that reasoning WFM.

The changes look good; merging.

@gnprice gnprice force-pushed the pr-link-long-press-error-catch branch from d7fa782 to ae4cf01 Compare April 25, 2024 22:16
@gnprice gnprice merged commit ae4cf01 into zulip:main Apr 25, 2024
1 check passed
@chrisbobbe chrisbobbe deleted the pr-link-long-press-error-catch branch April 25, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnprice gnprice Awaiting requested review from gnprice

Assignees
No one assigned
Labels
a-message list
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

msglist: Long-press on invalid link crashes the app
2 participants
@chrisbobbe @gnprice