-
-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add portable bindings for the filesystem #7428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
force-pushed
the
fs-bindings
branch
from
November 22, 2024 14:59
2d7784a
to
449f354
Compare
AlCalzone
force-pushed
the
fs-bindings
branch
from
December 10, 2024 15:51
76f37f7
to
ee3c587
Compare
@zwave-js-bot automerge |
zwave-js-bot
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds portable FS bindings that will later be used to support different platforms than Node.js
As a side effect, the
serial
package is now in charge of listing serial ports.Followup tasks:
fs-extra
fromjsonl-db
, replace with portable bindingsexeca
with portable bindings where supportedfs-extra
fromproper-lockfile
, replace with portable bindings