[2/3] Wasm CM support in frontend-wasm. Integration tests preparation (lazy IR compilation) #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenhat
force-pushed
the
greenhat/i80-wasm-cm-pr2-integ-tests-lazy-ir-build
branch
2 times, most recently
from
4294a3e to
b319fed
Compare
greenhat
force-pushed
the
greenhat/i80-wasm-cm-pr1-frontend-reorg
branch
from
6a2c302 to
adcb3b7
Compare
greenhat
force-pushed
the
greenhat/i80-wasm-cm-pr2-integ-tests-lazy-ir-build
branch
from
b319fed to
cd530d8
Compare
greenhat
force-pushed
the
greenhat/i80-wasm-cm-pr1-frontend-reorg
branch
from
adcb3b7 to
c9a6033
Compare
greenhat
changed the title
greenhat
force-pushed
the
greenhat/i80-wasm-cm-pr2-integ-tests-lazy-ir-build
branch
from
26a9f7b to
e244828
Compare
greenhat
force-pushed
the
greenhat/i80-wasm-cm-pr1-frontend-reorg
branch
from
c9a6033 to
5950b30
Compare
greenhat
force-pushed
the
greenhat/i80-wasm-cm-pr2-integ-tests-lazy-ir-build
branch
from
e244828 to
fb8aca3
Compare
greenhat
force-pushed
the
greenhat/i80-wasm-cm-pr1-frontend-reorg
branch
from
5950b30 to
a2b30fe
Compare
bitwalker
approved these changes
Jan 15, 2024
| @@ -20,7 +20,7 @@ thiserror.workspace = true | |||
| smallvec.workspace = true | |||
| log.workspace = true | |||
| anyhow.workspace = true | |||
| wasmparser = "0.107" | |||
There was a problem hiding this comment.
Any reason to keep this pinned to the build version vs minor? The former would've still installed 0.118.1 with a cargo update even though it mentions an older version. I don't have strong feelings either way, but I tend to pin to the minor version unless stability is a problem with a given crate.
There was a problem hiding this comment.
Minor would be enough here. I was unhappy with the breaking change below, so I was extra cautious.
Base automatically changed from
greenhat/i80-wasm-cm-pr1-frontend-reorg
to
main
January 16, 2024 08:55
bitwalker
deleted the
greenhat/i80-wasm-cm-pr2-integ-tests-lazy-ir-build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#80
This PR is the second in the stacked PRs and should be merged after #82
This PR splits Wasm and IR compilations and unifies the compilation pipeline, making all tests go through the same IR passes.