Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(memory): change vmstate memory type #1627

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

refactor(memory): change vmstate memory type #1627

wants to merge 1 commit into from

Conversation

0xSooki
Copy link

@0xSooki 0xSooki commented Jan 17, 2025

closes #1612

@0xSooki 0xSooki changed the title refactor(processor): change vmstate memory type refactor(memory): change vmstate memory type Jan 17, 2025
@bobbinth
Copy link
Contributor

Thank you for working on this! A couple of comments:

  • This work should probably be based on the element-addressable-memory branch.
  • Would be good to make more comprehensive changes here. For example, change addresses to u32 in places like this one as well.

An even more comprehensive change could be to introduce MemoryAddress(u32) newtype and use it everywhere. But that is also a much bigger undertaking.

@0xSooki
Copy link
Author

0xSooki commented Jan 22, 2025

I will continue working on it based on your suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xSooki @bobbinth