allow Node 20

.github/workflows/test-all-packages.yml

@@ -31,7 +31,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['16.x', '18.x']
+        node-version: ['18.x', '20.x']
     steps:
       - uses: actions/checkout@v3
         with:
@@ -98,7 +98,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        engine: ['16.x', '18.x', 'xs']
+        engine: ['18.x', '20.x', 'xs']
     steps:
       - name: set vars
         id: vars
@@ -186,7 +186,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        engine: ['16.x', '18.x', 'xs']
+        engine: ['18.x', '20.x', 'xs']
     steps:
       - name: set vars
         id: vars
@@ -305,7 +305,7 @@ jobs:
     strategy:
       matrix:
         # test:xs is noop in solo/package.json
-        engine: ['16.x', '18.x']
+        engine: ['18.x', '20.x']
     steps:
       - name: set vars
         id: vars
@@ -346,7 +346,7 @@ jobs:
     strategy:
       matrix:
         # test:xs is noop in cosmic-swingset/package.json
-        engine: ['16.x', '18.x', 'xs']
+        engine: ['18.x', '20.x', 'xs']
     steps:
       - name: set vars
         id: vars
@@ -390,7 +390,7 @@ jobs:
     strategy:
       matrix:
         # test:xs is noop in inter-protocol/package.json
-        engine: ['16.x', '18.x']
+        engine: ['18.x', '20.x']
     steps:
       - name: set vars
         id: vars
@@ -430,7 +430,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        engine: ['16.x', '18.x', 'xs']
+        engine: ['18.x', '20.x', 'xs']
     steps:
       - name: set vars
         id: vars
@@ -471,7 +471,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        engine: ['16.x', '18.x', 'xs']
+        engine: ['18.x', '20.x', 'xs']
     steps:
       - name: set vars
         id: vars
@@ -513,7 +513,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        engine: ['16.x', '18.x', 'xs']
+        engine: ['18.x', '20.x', 'xs']
     steps:
       - name: set vars
         id: vars
@@ -565,7 +565,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        engine: ['16.x', '18.x', 'xs']
+        engine: ['18.x', '20.x', 'xs']
     steps:
       - name: set vars
         id: vars
@@ -606,7 +606,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        engine: ['16.x', '18.x', 'xs']
+        engine: ['18.x', '20.x', 'xs']
     steps:
       - name: set vars
         id: vars
@@ -648,7 +648,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        engine: ['16.x', '18.x', 'xs']
+        engine: ['18.x', '20.x', 'xs']
     steps:
       - name: set vars
         id: vars
@@ -690,7 +690,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        engine: ['16.x', '18.x', 'xs']
+        engine: ['18.x', '20.x', 'xs']
     steps:
       - name: set vars
         id: vars

.node-version

@@ -0,0 +1 @@
+20.11.0

package.json

@@ -37,7 +37,7 @@
     "typescript": "^5.3.3"
   },
   "engines": {
-    "node": "^16.13 || ^18.12"
+    "node": "^16.13 || ^18.12 || ^20.9"
   },
   "prettier": {
     "arrowParens": "avoid",

packages/smart-wallet/test/test-addAsset.js

@@ -511,7 +511,7 @@ test.serial('non-vbank asset: give before deposit', async t => {
     const mockStorage = await consume.chainStorage;
     const { aPlayer } = makeScenario(t);
 
-    aPlayer(addr2, walletUIbridge, mockStorage, sendToBridge, updates);
+    await aPlayer(addr2, walletUIbridge, mockStorage, sendToBridge, updates);
     const c2 = goofyClient(mockStorage, walletUIbridge.promise);
     await t.throwsAsync(c2, { message: /Withdrawal of {.*} failed/ });
     await eventLoopIteration();

packages/smart-wallet/test/test-walletFactory.js

@@ -181,12 +181,12 @@ test('bad action value', async t => {
   await t.context.sendToBridge(validMsg);
 
   // the signal of an error is available in chain storage
-  t.deepEqual(await headValue(updates), {
-    updated: 'walletAction',
-    status: {
-      error: 'Unexpected token i in JSON at position 0',
-    },
-  });
+  const head = await headValue(updates);
+  // For type narrowing
+  assert(head.updated === 'walletAction');
+  // The rest of the error message is different in Node 18 vs 20. On chain it
+  // will come from an XS version that is in common across all validators.
+  t.regex(head.status.error, /Unexpected token/);
 });
 
 test('notifiers', async t => {

packages/swing-store/src/snapStoreIO.js

@@ -3,6 +3,6 @@ import { makeMeasureSeconds } from '@agoric/internal';
 
 export function makeSnapStoreIO() {
   return {
-    measureSeconds: makeMeasureSeconds(performance.now),
+    measureSeconds: makeMeasureSeconds(performance.now.bind(performance)),
   };
 }