allow Node 20 #8920
Merged
allow Node 20 #8920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 20 is more strict nodejs/node#47857
0xpatrickdev
approved these changes
Feb 15, 2024
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8900
Description
Update CI job that tests all packages to run in Node 18 and 20 instead of 16 and 18.
Our dapps integration is holding up dropping 16, but we don't support 16 anymore and must support 20. Until we can get the cross-repo dapp tests working we should ensure the packages work under Node 20. We don't need to test them on Node 16 anymore than the coverage provided by the dapp tests.
Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
We need to document our Node version and updating policy. I've drafted one in 2a981b0 but I think it can wait to land it until after it's true :)
Testing Considerations
CI
Upgrade Considerations
n/a