Camstim ephys #144
Merged
Camstim ephys #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f metadata schema
…ntate depdendency
| @@ -68,7 +67,7 @@ def __init__(self, session_id: str, json_settings: dict) -> None: | |||
| self.recording_dir = npc_ephys.get_single_oebin_path( | |||
| session_inst.lims_path | |||
| ).parent | |||
| except FileNotFoundError: | |||
| except: | |||
There was a problem hiding this comment.
why was the FileNotFoundError removed? Using a bare except without specifying an exception type will catch all exceptions, including ones that you might not intend to handle (like KeyboardInterrupt, SystemExit, or MemoryError).
This can make debugging more difficult so I'd recommend putting FileNotFoundError back or if you need to catch multiple types of errors you can do a tuple
There was a problem hiding this comment.
There was another error received here but I forget what it was. I should have written it down. I guess we can revert and if it shows up again I can commit again
| return stim_name | ||
|
|
||
|
|
||
| def get_stimulus_type(stimulus): | ||
| """ |
There was a problem hiding this comment.
It looks like all functions here have docstrings already. am I missing something?
mekhlakapoor
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why this wasn't caught elsewhere, or if it was, but it appears the latest schema has different objects so the camstim ephys class wouldn't work. Perhaps I'm mislead, but these changes appeared to be compatible.