-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camstim ephys #144
Merged
Merged
Camstim ephys #144
Changes from 115 commits
Commits
Show all changes
119 commits
Select commit
Hold shift + click to select a range
4f493af
add camstim session object
rcpeene f84515c
bump schema version
rcpeene 275a974
Fix syntax
rcpeene 17302c7
correct variable name
rcpeene 1dfaa25
remove opto table generation. that should be handled outside this repo
rcpeene 835e610
Add test
rcpeene 993ee93
pep codestyle
rcpeene 53fb855
Lint and update tests and docstrings
rcpeene ac62ba8
Merge branch 'main' into camstim-ephys
rcpeene ebb8d46
merge main into branch
mekhlakapoor 5e9c420
linters
mekhlakapoor 2aa9636
Rename CamstimSession -> CamstimEphysSession
rcpeene d450910
Merge branch 'camstim-ephys' of https://github.com/AllenNeuralDynamic…
rcpeene 9b29e56
Merge branch 'main' of https://github.com/AllenNeuralDynamics/aind-me…
rcpeene ecffa15
Adjust for new data schema imports. split camstim into camstim ephys …
rcpeene fe644e6
Lint, fix tests
rcpeene 4f26333
remove dependency npc_session
rcpeene ce3dde9
fix bug with retrieving probe letter. fix bug with incorrect import o…
rcpeene e706890
adding pkl functions
Ahad-Allen 214c39e
porting over utils
Ahad-Allen 5b04501
adding start and stop time functions
Ahad-Allen 2b1869e
renaming utils
Ahad-Allen 8d11041
Merge branch 'camstim-ephys' of https://github.com/AllenNeuralDynamic…
Ahad-Allen 24c8b4b
fix imports; replace npc_sync function with local sync_utils to elimi…
rcpeene c68c70b
woops! remove while(true) from cheap debugging
rcpeene c7e443d
documentation
Ahad-Allen 5412d67
Merge branch 'camstim-ephys' of https://github.com/AllenNeuralDynamic…
Ahad-Allen 90e2081
documentation
Ahad-Allen f9ffe4f
remove constants requirement
Ahad-Allen 99e5de8
linting
Ahad-Allen 2835b59
added build_stimulus_table and build_optogenetics_table to camstim an…
rcpeene bcb1e28
Merge branch 'camstim-ephys' of https://github.com/AllenNeuralDynamic…
rcpeene bf7e577
adding doc strings
Ahad-Allen f33a571
add docstring and option to overwrite tables for camstim and camstim-…
rcpeene 0faaf6a
Merge branch 'camstim-ephys' of https://github.com/AllenNeuralDynamic…
rcpeene ce11dc7
lint a bunch of files
rcpeene 1e75624
refactor overwrite_tables and opto_conditions_map into json settings …
rcpeene 9fc932a
fixing naming_utils
Ahad-Allen 81de5fc
fixing merge
Ahad-Allen 044d885
fix imports
rcpeene 9e2f46a
lint
rcpeene 317222a
fix function header
rcpeene 6eaea08
remove NA for stim names when missing
Ahad-Allen fbef07f
testing pkl functions
Ahad-Allen 5efb706
adding naming test
Ahad-Allen b48a4f1
creating sync tests
Ahad-Allen 195e3c6
cleaning up sync tests
Ahad-Allen c3f879e
adding heavily mocked tests
Ahad-Allen d12b51d
modifying ai generated tests
Ahad-Allen 3e4a55d
using copilot to make tests for many scenarios
Ahad-Allen d6b8a55
basic ai cases for math functions
Ahad-Allen fef571c
linting
Ahad-Allen 26679ad
resolve conflicts
mekhlakapoor 8d17180
WIP: linters
mekhlakapoor 9e272ad
removing long comments from naming
Ahad-Allen 932ae94
removing long comments from pkl
Ahad-Allen 8291bff
fixing excessive comments of test_sync
Ahad-Allen b4e7832
removing lambda function
Ahad-Allen 6e34d6b
fixing spaces before : in sync utils
Ahad-Allen ac3ef98
fixing test_syncs
Ahad-Allen faaf61a
changing sync meta functions for tests"
Ahad-Allen 38c6a09
fixing time import errors
Ahad-Allen 13500a9
fixing sync import errors
Ahad-Allen f433353
fixing more sync import errors
Ahad-Allen cfe112b
fixing sync import issues in tons of tests
Ahad-Allen 7f7e15f
fixing linting issues from importing
Ahad-Allen f21176a
moved files for coverage convention
Ahad-Allen 86ac09c
adding inits.py files
Ahad-Allen 18d579f
fixing test
Ahad-Allen 0fa6e43
fixing failed ignore_case
Ahad-Allen 3150e79
fixing test case for mapping that fails
Ahad-Allen 957e41d
fixing imports in toml
Ahad-Allen 5dc43c9
fixing missing doc strings
Ahad-Allen 19ed574
doc strings for tests
Ahad-Allen 30bf718
fixing interrogate
Ahad-Allen 6828315
fixing long doc strings
Ahad-Allen d5908bf
fixing space before colon
Ahad-Allen cf5fdc1
fixing one missing doc string
Ahad-Allen 6a69453
fixing imports for testing
Ahad-Allen 9a4c80e
fixing import issues?
Ahad-Allen 6712743
merge from main
mekhlakapoor eff2e17
moves utils into open_ephys
mekhlakapoor 6d22bde
replaces prints with logger
mekhlakapoor 6ac37dd
runs linters
mekhlakapoor 37d8440
Merge branch 'main' into camstim-ephys
mekhlakapoor ca6a5c5
utils coverage
mekhlakapoor 4625cf2
excluse E203 flake8
mekhlakapoor 5f89f0e
fix linter
mekhlakapoor 4a3c6dd
WIP: tests for behavior and stim utils
mekhlakapoor 08b44ad
adding some tests for stim utils
Ahad-Allen 7d9811c
generating and cleaning the rest of the func tests
Ahad-Allen b49d533
all stim tests pass
Ahad-Allen 43aaf23
finalizing behavior tests
Ahad-Allen b38939b
Adding imports to behavior calls
Ahad-Allen c9a0188
linting and fixes
Ahad-Allen 58def7a
linting + docstrings
Ahad-Allen afc0bf2
forgot one docstring
Ahad-Allen e3116fd
fixing copy paste mistake for behavior
Ahad-Allen 61355a9
flake8 fixes
Ahad-Allen 84a55be
resolves conflict
mekhlakapoor a3124cb
moving constants to new loc
Ahad-Allen 4a4fe5a
behavior for loop clean up
Ahad-Allen f312102
linting
Ahad-Allen ab23025
moving function into being a helper
Ahad-Allen eead07b
resolve merge
rcpeene 13b7f0c
Merge branch 'camstim-ephys' of https://github.com/AllenNeuralDynamic…
rcpeene ebdfbd9
rename costants.py to constants.py
rcpeene 46e8a21
fix small bugs
rcpeene 439753e
linted and fix bug with NaNs appearing for spontaneous periods in sti…
rcpeene 39415d5
except other errors for getting ecephys paths
rcpeene aab9728
Merge branch 'main' of https://github.com/AllenNeuralDynamics/aind-me…
rcpeene ebd8f8b
Merge branch 'main' of https://github.com/AllenNeuralDynamics/aind-me…
rcpeene 3167039
Merge branch 'main' into camstim-ephys
rcpeene dbc69c7
update probe objects for latest schema;
rcpeene 2322d97
fix assignment of stim name to accomodate multiple keys from pkl file
rcpeene 25528e6
Merge branch 'dev' of https://github.com/AllenNeuralDynamics/aind-met…
rcpeene 0561a40
address feedback, fix linting
rcpeene 8f99299
address more linting
rcpeene 8b1b653
argh linting
rcpeene File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -579,13 +579,13 @@ def read_stimulus_name_from_path(stimulus): | |
""" | ||
|
||
stim_name = stimulus["stim_path"].split("\\")[-1].split(".")[0] | ||
|
||
if len(stim_name) == 0: | ||
stim_name = stimulus["stim_path"].split("\\\\")[-2] | ||
|
||
|
||
if stimulus["stim_path"] == "": | ||
stim_name = stimulus["movie_local_path"].split("\\")[-1].split(".")[0] | ||
else: | ||
stim_name = stimulus["stim_path"].split("\\")[-1].split(".")[0] | ||
return stim_name | ||
|
||
|
||
def get_stimulus_type(stimulus): | ||
""" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fill in docstrings There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like all functions here have docstrings already. am I missing something? |
||
Obtains the stimulus type from the stimulus dictionary. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was the FileNotFoundError removed? Using a bare except without specifying an exception type will catch all exceptions, including ones that you might not intend to handle (like KeyboardInterrupt, SystemExit, or MemoryError).
This can make debugging more difficult so I'd recommend putting FileNotFoundError back or if you need to catch multiple types of errors you can do a tuple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was another error received here but I forget what it was. I should have written it down. I guess we can revert and if it shows up again I can commit again