Don't change type
property on textarea
#77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the code would try to set a <textarea>'s
type
attribute tothis.type
. However, a textarea element'stype
property is readonly, and in some environments†, an Error is thrown:Now, the code behaves more or less the same way, but skips trying to assign
type
to textareas.†I haven't been able to pinpoint why it happens sometimes and not others, but one major difference is browserify vs. rollup (Errors happen when using the latter).
This is a non-breaking change. However, I have spotted some other bugs, such as not handling switching from
"textarea"
type to non-"textarea
type (aka an input element). That fix will come in another PR, and will be a breaking change.