-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0.4] Fix nodeos_startup_catchup test #1033
Conversation
Can you explain why the number of unlinkable blocks is bounded by |
The idea is, it is inevitable to have some unlinkable blocks; the worst case is all blocks in a batch are temporarily unlinkable. |
Note:start |
The test is broken in
Rel 1.0.3
and flaky inmain
. The counts the number ofunlinkable_block
occurrences in logging files and make sure it is not greater than500
.But in
Rel 1.0.3
,unlinkable_block
(part ofunlinkable_block_exception
) shows up 3 times per unlinkable block, for example:This PR searches for
unlinkable_block_exception connection - \d+: #(\d+)
, extracts the unlinkable block number, and verifies thatResolves #1015