Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MAXAR_mesh_variants extension #465

Merged
merged 6 commits into from
Mar 22, 2022
Merged

Add MAXAR_mesh_variants extension #465

merged 6 commits into from
Mar 22, 2022

Conversation

nithinp7
Copy link
Contributor

@nithinp7 nithinp7 commented Mar 21, 2022

Add support for the MAXAR_mesh_variants extension:

  • Add auto-generated files for the extension.
  • Small fixes in the glTF code generator to enable generating the extension.

For an example front-end integration using this extension see: CesiumGS/cesium-unreal#773.

For logistical reasons, includes the changes from #463

@nithinp7 nithinp7 requested a review from kring March 21, 2022 20:02
@nithinp7
Copy link
Contributor Author

@kring I finally opened this, it is just the auto-generated code and the improvements to the generator that you made. I had made an earlier attempt at creating a workaround in the generator by introducing the "manuallyDefined" option in the glTF.json. I used the new option in tools/generate-classes/index.json. If that option isn't necessary after your generator changes, feel free to remove it (or let me know and I'll remove it).

@nithinp7 nithinp7 changed the base branch from main to is-metadata-array March 21, 2022 20:18
@kring
Copy link
Member

kring commented Mar 22, 2022

Thanks @nithinp7. Please update CHANGES.md in main to mention the new extension.

@kring kring merged commit 8f898e6 into is-metadata-array Mar 22, 2022
@kring kring deleted the node-variants branch March 22, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants