Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Elution Buffer fields in Arnold twist #570

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

idalindegaard
Copy link
Contributor

@idalindegaard idalindegaard commented Dec 17, 2024

Part of issue #568

Added

  • New process UDFs: "Lot no: Elution Buffer" in buffer_exchange.py, aliquot_samples_for_enzymatic_fragmentation_trist.py and bead_purification_twist.py

Changed

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@idalindegaard
Copy link
Contributor Author

Tested the changes on stage for sample ACC15408A1

Recorded in LIMS

The values recorded for "Lot no: Elution Buffer" in the LIMS steps Buffer Exchange, Aliquot Samples for enzymatic fragmentation TWIST and Target Enrichment TWIST:
Screenshot 2024-12-17 at 10 42 46
Screenshot 2024-12-17 at 10 45 59
Screenshot 2024-12-17 at 10 59 27

Successful run of EPP "Arnold Upload twist"
Screenshot 2024-12-17 at 11 00 54

Results in the database

Screenshot 2024-12-18 at 16 09 50
Screenshot 2024-12-18 at 16 11 05
Screenshot 2024-12-18 at 16 11 32

Conclusion

The new fields were successfully populated

Copy link
Collaborator

@Karl-Svard Karl-Svard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! 🔥

@idalindegaard idalindegaard merged commit 4d3d351 into master Dec 18, 2024
2 checks passed
@idalindegaard idalindegaard deleted the twist_arnold_buffer_udf branch December 18, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants