-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#521: Enrich synthetic data set with shared blocks #522
#521: Enrich synthetic data set with shared blocks #522
Conversation
Now ready for review @lifflander @cwschilly |
@tlamonthezie I rebased this PR on top of
Do you know what is wrong here? Thanks. |
…seStepper and render it
0812dad
to
7fbbda1
Compare
Update: the same error happens for me with |
I confirm @cwschilly that your change fixed the problem with the LB data file schema file. PR can be reviewed @cwschilly @lifflander, in the default setting that comes with this PR, any other load-balancer (whether it is vt's N.B.: the rendered edges in the figures above must be disregarded as they correspond to the VTK problem on certain versions of macOS. |
…ting that must reach 0 imbalance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* #521: description, constructing script, and dataset files * #521: Configuration file to run the synthetic+blocks case through PhaseStepper and render it * #521: modified example and specification * #521: new test case * #521: excluse pngs from trailing whitespace check * #521: fix png whitespace error * #521: pull in LBDatafile_schema.py with JSON_data_files_validator.py * #521: finalized example and configuration with baseline load-only setting that must reach 0 imbalance * #521: generalize whitespace check to ignore all pngs * #521: remove unused imports --------- Co-authored-by: Caleb Schilly <[email protected]>
Resolves #521
**DO NOT MERGE BEFORE #509 (PR #516) **