-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#32: vt-tv: Improve CI #85
Conversation
d3649ce
to
7d4bb07
Compare
e00116d
to
d30e481
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor changes--everything looks great on the whole. I do think we should test the content of the mesh files though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create follow-on issues @tlamonthezie for aspects that are not covered yet by CI but that we discussed at last meeting.
Hi @ppebay I created an issue to continue to work on the CI/Tests see #95 . Some additional things than those discussed have also been added. |
baaa683
to
a8c16ec
Compare
This is a huge PR. You might consider breaking it up into multiple PRs if it gets difficult to get everything passing. |
b79b3db
to
be002d7
Compare
53df383
to
33ca721
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that style varies from file to file and I wonder if we should implement vt's style guidelines here as well, perhaps as a separate PR so we can get this merged sooner rather than later.
vt has a tool that will check/correct the header comments at the tops of files, including setting the correct filenames. There are more files that need to be corrected than I marked.
58e03bc
to
74e084b
Compare
Fixes #32
Fixes #92
Fixes #103
Might fix #69
Important! Dockerhub repository is modified from that PR (now same that
vt
one). Base docker images are used for unit tests and are not already pushed to the new repository which will generate failures on CI until merge is done.One of the latest run (using old repository) can be found at https://github.com/DARMA-tasking/vt-tv/actions/runs/10177046856
After merging please call the
pushdockerimage
action to push base images (with VTK) to the new Dockerhub repository. Until that CI will failThis PR includes:
Unit tests refactoring and writing:
tests
&example
directorieslib
directory + update the fetch script.tests/unit
and build tests in a single executable for Google test optimal use.build.sh
script capable for local use as well as for ci use with some options for build, coverage and test run. get more info withbuild.sh --help
. This provides for example a way to generate coverage html report, JUnit report etc.tests/test_image.sh
(Call internally a python module for now to diff between actual and expected png image). (This is called by the ParseRenderTest class after rendering with theccm_example0.png
generated file).lb_synthetic_data
using thecreate_synthetic_attributes_data.py
script (and reorganize generated attributes alphabetically in the python script)CI:
xvfb
as graphics display in CI.ci/docker/build-and-test.dockerfile
and called shell script for details.5.1 Configurable base image:
ci/docker/make-base.dockerfile
used by the.github/workflows/pushbasedockerimage.yml
. Thepushbasedockerimage
contains now an input to select the image to build and push to DockerHub.5.2 Configurable vt-tv build & test image
ci/docker/build-and-test.dockerfile
used by the.github/workflows/build-and-test.yml
workflow5.3 Provide test matrix using the 3 images in the build & test workflow:
ubuntu_22.04-gcc_11-vtk_9.2.2-py_3.8
(Build, Test)ubuntu_22.04-clang_14-vtk_9.2.2-py_3.8
(Build, Test)ubuntu_22.04-gcc_12-vtk_9.3.0-py_3.8
(Build, Test, Coverage)Because docker images are more scalable it will be easier to add later additional configurations to the
pushbasedockerimage.yml
workflow and to add it to tests in thebuild-and-test.yml
images to build vt-tv on and to run tests on.Additionnaly the
ci
folderhas been re-organized and docker images are now in the new
ci/docker` directoryAdditionally added fix from #92 to make checks successful for clang.