Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#95: Improve CI rendering tests #96

Merged
merged 48 commits into from
Sep 4, 2024
Merged

#95: Improve CI rendering tests #96

merged 48 commits into from
Sep 4, 2024

Conversation

tlamonthezie
Copy link
Contributor

@tlamonthezie tlamonthezie commented Jul 31, 2024 •
edited
Loading

Fixes #95

CI improvements in continuation to issue #32 PR #85 in particular for rendering tests (VTP and PNG).

This PR provides

  • Better image and mesh testing: set object_jitter value to 0.0 for test configurations to disable randomness in point placement. Then the rendering tests can be efficient to test output files against expected (*.vtp|*.png)
  • Improve testing code quality and output
  • Move datasets from {project_dir}/tests/data datasets to {project_dir}/data
  • Fix tests badge url in README.md
  • Add XVBF usage as an option of build.sh for running tests

@tlamonthezie tlamonthezie self-assigned this Jul 31, 2024
@tlamonthezie tlamonthezie force-pushed the 95-improve-ci-rendering-tests branch from 576230f to 7a39b0c Compare August 26, 2024 12:06
@tlamonthezie
#32: move googletest dependency sources to lib & rupdate script to fe…
dc5a9b8 
…tch & add VT_TV_TEST_ENABLED option
@tlamonthezie
#32: make unique build script working either in CI or locally
51ca230
@tlamonthezie
#95: WIP add tests using the VTK vtkPolyDataReader for generated meshes
ebbc071
@tlamonthezie
#95: WIP add printing for some values from VTK in test
83d796f
@tlamonthezie
#95: improve granular vtk mesh tests
b0480ed
@tlamonthezie
#95: remove unnecessary assert
0604fa2
@tlamonthezie
#95: WIP option to set object jitter dimensions in Render class with …
920ab56 
…new VT_TV_OBJECT_JITTER_DIMS_FILE env
@tlamonthezie
#95: fix some compile issues
045c546
@tlamonthezie
#95: WIP testing images add file support to load ans save jitter dims…
215c77a 
… for tests
@tlamonthezie
#95: WIP fix problemns in render test
41bac36
@tlamonthezie
#95: fix invalid output path in a test
50d817b
@tlamonthezie
#95: fix missing output jitter file
36105cf
@tlamonthezie
#95: fix a path
2b6a81a
@tlamonthezie
#95: fix test logic
f60c6fc
@tlamonthezie
#95: update workflow for tests
381f143
@tlamonthezie
#95: add csv artifacts to ci
2b2924e
@tlamonthezie
#95: update expected image set and add jitter dims
99bcd77
@tlamonthezie
#95: move data folder to top level
96bcf51
@tlamonthezie
#95: update new path to data files in source and config files
77fc4da
@tlamonthezie
#95: fix build warning
6a87d70
@tlamonthezie
#95: update expected ccm_example output
1a9bd51
@tlamonthezie
#95: fix invalid default value in dockerfile arg
390c3e2
@tlamonthezie
#95: update dockerfile default args
7ca17b2
@tlamonthezie
#95: add readme in ci docker directory
9790891
@tlamonthezie
#95: restore raw diff tests for vtp files
ccd8ee5
@tlamonthezie
#95: remove trailing whitespace
4eeb038
@tlamonthezie
#95: restore missing build script for ci
2db60c7
@tlamonthezie
#95: fix build and test badge url in README
0b573ac
@tlamonthezie tlamonthezie marked this pull request as ready for review August 27, 2024 13:11
cwschilly
cwschilly reviewed Aug 27, 2024
View reviewed changes
.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
ci/build.sh Outdated Show resolved Hide resolved
src/vt-tv/render/render.h Outdated Show resolved Hide resolved
tests/unit/render/test_parse_render.cc Outdated Show resolved Hide resolved
tests/unit/render/test_render.cc Outdated Show resolved Hide resolved
@cwschilly cwschilly mentioned this pull request Aug 27, 2024
Merged
@tlamonthezie tlamonthezie force-pushed the 95-improve-ci-rendering-tests branch from 3299df3 to f6be209 Compare August 27, 2024 18:16
@tlamonthezie tlamonthezie marked this pull request as draft August 27, 2024 18:17
@tlamonthezie tlamonthezie force-pushed the 95-improve-ci-rendering-tests branch 2 times, most recently from 2f9dac3 to a98964b Compare August 27, 2024 18:28
@tlamonthezie tlamonthezie marked this pull request as ready for review August 27, 2024 18:30
@tlamonthezie tlamonthezie force-pushed the 95-improve-ci-rendering-tests branch from a98964b to 09efa62 Compare August 27, 2024 18:31
@tlamonthezie tlamonthezie requested a review from cwschilly August 28, 2024 10:19
cwschilly
cwschilly requested changes Aug 28, 2024
View reviewed changes
tests/unit/deps/test_vtk.cc Outdated Show resolved Hide resolved
This was referenced Aug 28, 2024
Merged
Merged
@tlamonthezie tlamonthezie requested a review from cwschilly August 29, 2024 12:18
cwschilly
cwschilly approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@cwschilly cwschilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlamonthezie tlamonthezie merged commit bb91fb3 into master Sep 4, 2024
8 checks passed
@cwschilly cwschilly deleted the 95-improve-ci-rendering-tests branch September 4, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwschilly cwschilly cwschilly approved these changes

@lifflander lifflander Awaiting requested review from lifflander

@pierrepebay pierrepebay Awaiting requested review from pierrepebay

Assignees

@tlamonthezie tlamonthezie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve CI rendering tests
2 participants
@tlamonthezie @cwschilly