Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI rendering tests #95

Closed
2 tasks done
tlamonthezie opened this issue Jul 29, 2024 · 1 comment · Fixed by #96
Closed
2 tasks done

Improve CI rendering tests #95

tlamonthezie opened this issue Jul 29, 2024 · 1 comment · Fixed by #96
Assignees
@tlamonthezie

Comments

@tlamonthezie
Copy link
Contributor

tlamonthezie commented Jul 29, 2024 •
edited
Loading

Follows up of #32

  • Improve output testing (VTP, PNG)
  • Fix invalid badge in README
@tlamonthezie tlamonthezie changed the title Improve Test image rendering Improve image rendering tests Jul 29, 2024
@tlamonthezie tlamonthezie changed the title Improve image rendering tests Improve image rendering tests in CI Jul 29, 2024
@tlamonthezie tlamonthezie changed the title Improve image rendering tests in CI Improve CI Jul 29, 2024
@tlamonthezie tlamonthezie self-assigned this Jul 29, 2024
@tlamonthezie tlamonthezie mentioned this issue Jul 29, 2024
Merged
@tlamonthezie tlamonthezie changed the title Improve CI Improve CI rendering tests Jul 29, 2024
tlamonthezie added a commit that referenced this issue Jul 29, 2024
@tlamonthezie
#95: WIP add tests using the VTK vtkPolyDataReader for generated meshes
895bbd6
tlamonthezie added a commit that referenced this issue Jul 29, 2024
@tlamonthezie
#95: WIP add printing for some values from VTK in test
77d5977
tlamonthezie added a commit that referenced this issue Jul 29, 2024
@tlamonthezie
#95: improve granular vtk mesh tests
812ac16
tlamonthezie added a commit that referenced this issue Jul 29, 2024
@tlamonthezie
#95: remove unnecessary assert
600c291
@tlamonthezie
Copy link
Contributor Author

tlamonthezie commented Jul 30, 2024 •
edited
Loading

Comparing different output with same data: the objects are not placed at the same coordinates.
It is because the Render inner use internally some random logic for object placement using some object jitter.

To efficiently make comparisons between VTP or PNG output files a possible solution could be to save jitter_dims_ value for expected file and a way to use these Render::jitter_dims_ in a new Render instance.

tlamonthezie added a commit that referenced this issue Jul 30, 2024
@tlamonthezie
#95: WIP option to set object jitter dimensions in Render class with …
91944a0 
…new VT_TV_OBJECT_JITTER_DIMS_FILE env
tlamonthezie added a commit that referenced this issue Jul 30, 2024
@tlamonthezie
#95: fix some compile issues
9b9c770
tlamonthezie added a commit that referenced this issue Jul 30, 2024
@tlamonthezie
#95: WIP testing images add file support to load ans save jitter dims…
0c49842 
… for tests
tlamonthezie added a commit that referenced this issue Jul 30, 2024
@tlamonthezie
#95: WIP fix problemns in render test
647e42d
tlamonthezie added a commit that referenced this issue Jul 30, 2024
@tlamonthezie
#95: fix invalid output path in a test
8779eae
tlamonthezie added a commit that referenced this issue Jul 30, 2024
@tlamonthezie
#95: fix missing output jitter file
c9b8fc5
tlamonthezie added a commit that referenced this issue Jul 30, 2024
@tlamonthezie
#95: fix a path
22f62e7
tlamonthezie added a commit that referenced this issue Jul 31, 2024
@tlamonthezie
#95: fix test logic
252d077
tlamonthezie added a commit that referenced this issue Jul 31, 2024
@tlamonthezie
#95: update workflow for tests
40b9b57
tlamonthezie added a commit that referenced this issue Jul 31, 2024
@tlamonthezie
#95: add csv artifacts to ci
1181b07
tlamonthezie added a commit that referenced this issue Jul 31, 2024
@tlamonthezie
#95: update expected image set and add jitter dims
740d859
tlamonthezie added a commit that referenced this issue Jul 31, 2024
@tlamonthezie
#95: move data folder to top level
456e89f
tlamonthezie added a commit that referenced this issue Jul 31, 2024
@tlamonthezie
#95: update new path to data files in source and config files
1200ba7
tlamonthezie added a commit that referenced this issue Jul 31, 2024
@tlamonthezie
#95: temporary change object qoi for ccm example
3bde64d
tlamonthezie added a commit that referenced this issue Jul 31, 2024
@tlamonthezie
#95: fix build warning
12d4192
tlamonthezie added a commit that referenced this issue Jul 31, 2024
@tlamonthezie
#95: update expected ccm_example output
7c46e2f
tlamonthezie added a commit that referenced this issue Jul 31, 2024
@tlamonthezie
#95: fix invalid default value in dockerfile arg
15c6749
tlamonthezie added a commit that referenced this issue Jul 31, 2024
@tlamonthezie
#95: update dockerfile default args
864c4c6
tlamonthezie added a commit that referenced this issue Jul 31, 2024
@tlamonthezie
#95: add readme in ci docker directory
d6cd7de
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: fix build and test badge url in README
0b573ac
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: test reduceimage diff tolerance in unit test
cc93849
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: test reduceimage diff tolerance in unit test
f93355a
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: fix object qoi in test config file
f68869c
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: add test assertions and output in test_render
21b75e8
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: remove trailing whitespace
a1f265b
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: fix output error
9ffb3ea
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: update ouput in a test
539281e
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: upgrade image test tolerance value
191407c
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: add option to build script to run tests using xvbf
e265208
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: refactor xvfb usage for ci script
dd891fa
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: fix printing error
4342f65
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: fix expected vtp content for ccm example
f134d6b
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: fix fetch google test script type
bf6b38a
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: refresh googletest install to remove unnecessary files
308359a
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: fix variable name casing for consistency
f2a7e72
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: changes for pr
5c18b10
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: remove non working output to ci
27fc6c2
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: try using object jitter zero values to break randomness in rende…
3299df3 
…ring for ci tests
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: try using object jitter zero values to break randomness in rende…
f6be209 
…ring for ci tests
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: try using object jitter zero values to break randomness in rende…
2f9dac3 
…ring for ci tests
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: try using object jitter zero values to break randomness in rende…
a98964b 
…ring for ci tests
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: try using object jitter zero values to break randomness in rende…
09efa62 
…ring for ci tests
tlamonthezie added a commit that referenced this issue Aug 27, 2024
@tlamonthezie
#95: set small tolerance for png test as it should be zero in CI
08e9a21
This was referenced Aug 28, 2024
Merged
Merged
tlamonthezie added a commit that referenced this issue Aug 29, 2024
@tlamonthezie
#95: add missing newline
0acef5d
tlamonthezie added a commit that referenced this issue Aug 29, 2024
@tlamonthezie
#95: fix typo
b80c877
tlamonthezie added a commit that referenced this issue Sep 4, 2024
@tlamonthezie
Merge pull request #96 from DARMA-tasking/95-improve-ci-rendering-tests
bb91fb3 
#95: Improve CI rendering tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlamonthezie tlamonthezie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#95: Improve CI rendering tests DARMA-tasking/vt-tv
1 participant
@tlamonthezie