Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vt-tv cannot handle shared_block_id object QOI #80

Closed
ppebay opened this issue Jun 28, 2024 · 3 comments · Fixed by #94
Closed

vt-tv cannot handle shared_block_id object QOI #80

ppebay opened this issue Jun 28, 2024 · 3 comments · Fixed by #94
Assignees
Labels
enhancement New feature or request High Priority To be addressed before low priority

Comments

@ppebay
Copy link
Contributor

ppebay commented Jun 28, 2024

  • steps to reproduce:
    execute the `ccm-example.yaml' configuration with LBAF, as it invokes vt-tv for that QOI

  • the problem:

Screenshot 2024-06-28 at 08 45 49

Other block-related QOIs are mostly impacted equally

@ppebay ppebay added enhancement New feature or request High Priority To be addressed before low priority labels Jun 28, 2024
@tlamonthezie
Copy link
Contributor

@pierrepebay for your information you will find - in currently active #32 branch - the 2 example data files and configurations files (imported and adapted from the DARMA-tasking/LB-analysis-framework repository) as it was requested in #32 by @ppebay.
If it can help you to save some time.

@cwschilly cwschilly self-assigned this Jul 17, 2024
@cwschilly
Copy link
Contributor

cwschilly commented Jul 17, 2024

@ppebay @tlamonthezie @pierrepebay

The immediate solution to this is to change the user_defined field of the JSON to be attributes instead. For example:

"tasks": [
  {
    "entity": {
      "home": 1,
      "id": 2,
      "migratable": true,
      "type": "object"
    },
    "node": 1,
    "resource": "cpu",
    "time": 5.0,
    "attributes": {
      "shared_id": 1,
      "shared_bytes": 15000.0,
      "home_rank": 1
    }
  }
],

Any attributes can then be called as QOI in the config file:

viz:
  rank_qoi: load
  object_qoi: shared_id

This brings up a larger question of the difference between the user_defined and attributes fields.

It seems like user_defined was initially intended to provide "phase-level information (like t or dt from the application)" (vt#2171), while the attributes field was meant to "allow arbitrary attributes per rank and object to be selected as QOIs" (vt#2229).

Should we update LBAF to adhere to this distinction (it looks like LBAF doesn't support the attributes field)? Or should vt-tv treat the user_defined field as representing QOI as well?

@cwschilly
Copy link
Contributor

Should we update LBAF to adhere to this distinction (it looks like LBAF doesn't support the attributes field)? Or should vt-tv treat the user_defined field as representing QOI as well?

After discussing with @ppebay , we will treat the user_defined field the same as attributes

@cwschilly cwschilly linked a pull request Jul 26, 2024 that will close this issue
lifflander added a commit that referenced this issue Jul 31, 2024
…ed_block_id-object-qoi

#80:  vt-tv cannot handle shared_block_id object QOI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request High Priority To be addressed before low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants