Split the problem text content from the problem in the database. #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
force-pushed
the
split-problem-text-from-problem
branch
from
1d05c31 to
748eabe
Compare
vmcj
reviewed
Nov 24, 2023
vmcj
reviewed
Nov 24, 2023
vmcj
requested changes
Nov 24, 2023
nickygerritsen
force-pushed
the
split-problem-text-from-problem
branch
from
748eabe to
770da79
Compare
nickygerritsen
added a commit
to nickygerritsen/domjudge
that referenced
this pull request
Nov 24, 2023
Similar to DOMjudge#2241 this gets rid of the only other partial query.
nickygerritsen
added a commit
to nickygerritsen/domjudge
that referenced
this pull request
Nov 24, 2023
Similar to DOMjudge#2241 this gets rid of the only other partial query.
nickygerritsen
added a commit
to nickygerritsen/domjudge
that referenced
this pull request
Nov 24, 2023
Similar to DOMjudge#2241 this gets rid of the only other partial query.
nickygerritsen
added a commit
to nickygerritsen/domjudge
that referenced
this pull request
Nov 24, 2023
Similar to DOMjudge#2241 this gets rid of the only other partial query. Submission files should be pretty small and only the jury submission page displays this information anyway, so it should be safe to load the whole model.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 25, 2023
Similar to #2241 this gets rid of the only other partial query. Submission files should be pretty small and only the jury submission page displays this information anyway, so it should be safe to load the whole model.
This is to prepare for the next Doctrine release, which doesn't allow partial queries anymore. This is also to make it consistent with other blobs in the database like submission files and problem attachments. This is preparation for DOMjudge#2069.
nickygerritsen
force-pushed
the
split-problem-text-from-problem
branch
from
770da79 to
2ec6576
Compare
|
I propose to merge this after the current contest 'season', unless others think we should do it before so we can test it? |
vmcj
approved these changes
Jan 12, 2024
vmcj
pushed a commit
to vmcj/domjudge
that referenced
this pull request
Jan 12, 2024
Similar to DOMjudge#2241 this gets rid of the only other partial query. Submission files should be pretty small and only the jury submission page displays this information anyway, so it should be safe to load the whole model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prepare for the next Doctrine release, which doesn't allow partial queries anymore. This is also to make it consistent with other blobs in the database like submission files and problem attachments.
This is preparation for #2069 where I will do a similar thing.
Besides this there is one more partial query, which I will remove in a separate PR.
I know changing database stuff just for the ORM is not something to do lightly, but I don't think we have any better way. And this actually improves queries in the places where we used partial queries before IMHO.