Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export sql parser EntityContext types #157

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix: export sql parser EntityContext types #157

merged 1 commit into from
Nov 15, 2024

Conversation

liuxy0551
Copy link
Collaborator

@liuxy0551 liuxy0551 requested a review from Cythia828 November 14, 2024 08:15
Cythia828
Cythia828 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@Cythia828 Cythia828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@liuxy0551 liuxy0551 force-pushed the fix_sql_parser_371 branch 2 times, most recently from 004d49a to a683456 Compare November 14, 2024 08:20
mumiao
mumiao reviewed Nov 14, 2024
View reviewed changes
package.json
@@ -67,7 +67,7 @@
"pre-commit": "npx pretty-quick --staged"
},
"dependencies": {
"dt-sql-parser": "4.0.2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个如果是本地做开发迭代，不建议在这里改成beta版本，提合并main分支的PR，直接本地验证即可，可以在本地link下，测试验证，真正提测的时候再走release流程

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你说的对，monaco-sql-languages 的 version 改动我知道不提上来，这里遗漏了

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

想起来了，需要带上变更。
原因：使用旧版本的 dt-sql-parser 会发现 dt-sql-parser 没有导出这几个类型，带来的问题就是 CI 会不通过、使用这个 beta 包的 monaco-sql-languages 会出现导出异常。
解决：目标分支改为新切出的 next 分支

@liuxy0551 liuxy0551 changed the base branch from main to next November 14, 2024 08:50
@liuxy0551
Copy link
Collaborator Author

已通过 [email protected] 和 [email protected] 验证通过

@mumiao
Copy link
Collaborator

mumiao commented Nov 15, 2024

+1

@mumiao mumiao merged commit c1b619c into DTStack:next Nov 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumiao mumiao mumiao left review comments

@Cythia828 Cythia828 Cythia828 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuxy0551 @mumiao @Cythia828