Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export sql parser EntityContext types #157

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix: export sql parser EntityContext types #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"pre-commit": "npx pretty-quick --staged"
},
"dependencies": {
"dt-sql-parser": "4.0.2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个如果是本地做开发迭代，不建议在这里改成beta版本，提合并main分支的PR，直接本地验证即可，可以在本地link下，测试验证，真正提测的时候再走release流程

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你说的对，monaco-sql-languages 的 version 改动我知道不提上来，这里遗漏了

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

想起来了，需要带上变更。
原因：使用旧版本的 dt-sql-parser 会发现 dt-sql-parser 没有导出这几个类型，带来的问题就是 CI 会不通过、使用这个 beta 包的 monaco-sql-languages 会出现导出异常。
解决：目标分支改为新切出的 next 分支

"dt-sql-parser": "4.1.0-beta.4"
},
"peerDependencies": {
"monaco-editor": ">=0.31.0"
Expand Down
15 changes: 8 additions & 7 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ export type {
Suggestions,
TextSlice,
ParseError,
StmtContext,
EntityContext,
StmtContext
CommonEntityContext,
ColumnEntityContext,
FuncEntityContext
} from 'dt-sql-parser';