Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single generic testing stand setup guide #753

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Single generic testing stand setup guide #753

merged 6 commits into from
Mar 4, 2024

Conversation

filipleple
Copy link
Member

No description provided.

@filipleple filipleple self-assigned this Jan 26, 2024
@filipleple filipleple marked this pull request as ready for review February 8, 2024 11:29
@filipleple filipleple changed the title Remove ex021 overlap Single generic testing stand setup guide Feb 8, 2024
@filipleple filipleple force-pushed the ex021-revision branch 2 times, most recently from f529389 to 730ca8e Compare February 13, 2024 15:05
@filipleple
Copy link
Member Author

filipleple commented Feb 13, 2024

dead links fixed aside from link to deleted coreboot branch in old DTS version changelog, not sure how to resolve

@macpijan
Copy link
Contributor

to deleted coreboot branch in old DTS version changelog, not sure how to resolve

Let's replace with the link to the repository, with no specific branch.

@filipleple
Copy link
Member Author

CI fully satisfied

@macpijan macpijan requested a review from pkubaj February 27, 2024 12:04
@BeataZdunczyk BeataZdunczyk requested a review from mkopec March 4, 2024 12:04
Copy link
Member

@mkopec mkopec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Signed-off-by: Michał Kopeć <[email protected]>
@mkopec mkopec merged commit 79b608d into master Mar 4, 2024
3 of 4 checks passed
@mkopec mkopec deleted the ex021-revision branch March 4, 2024 17:13
connection via serial and external flashing.
* Sonoff - if we need line voltage control.
* PiKVM - if it is not possible to read the device via serial or it is limited,
it is possible to simulate the keyboard and read the image from HDMI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the required wires and components be listed here in a comprehensive manner? I guess nobody should even start work without having all the elements.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed here

|:---------:|:-----------------------------:|
| J11 pin 5 | PWR_ON# |
| J11 pin 6 | RST# |
| J15 pin 1 | GND |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filipleple I have concerns regarding this table; in the case of PC Engines, pin5 is RST, and pin6 is PWR; otherwise, it doesn't work. Could that be some mistake? Can we check that for Protectli, as it seems to be a reference in this guide?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filipleple
In a few spots, we mention the RTE version.
I think we should add a note saying this documentation is based on RTE v1.1.

RTE v1.1

RTE v1.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've added a note recommending using RTE v1.1, and following notes accounting for the differences here

@filipleple
Copy link
Member Author

Addressing the new review in #971

@filipleple filipleple removed the request for review from pkubaj January 3, 2025 09:27
@filipleple filipleple requested a review from dawidlesiak January 3, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants