Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Cannot locally test azul-docker-elasticsearch changes (DataBiosphere/azul#5986) #4

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

dsotirho-ucsc
Copy link
Contributor

@dsotirho-ucsc dsotirho-ucsc commented Mar 12, 2024

@dsotirho-ucsc dsotirho-ucsc force-pushed the issues/dsotirho-ucsc/5986-test-images-locally branch 3 times, most recently from 822cc0a to 9d5442e Compare March 13, 2024 20:02
README.md Outdated
Comment on lines 18 to 21
# To test the image in Azul, you will need to temporarily modify Azul's
# `environment.py` to set the appropriate `azul_docker_images` value using the
# full image name noted above (starting with "localhost"). With this change in
# place, run:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the change, and add

(cd ../azul && git diff)

and include it's output.

@dsotirho-ucsc dsotirho-ucsc force-pushed the issues/dsotirho-ucsc/5986-test-images-locally branch from 9d5442e to d785bfc Compare March 20, 2024 21:26
@hannes-ucsc hannes-ucsc merged commit 8c56659 into main Mar 26, 2024
1 check passed
@hannes-ucsc hannes-ucsc deleted the issues/dsotirho-ucsc/5986-test-images-locally branch March 26, 2024 06:02
@hannes-ucsc hannes-ucsc removed their assignment Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants