Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show warning on non "dataset" tabs (#899) #3609

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

frano-m
Copy link
Contributor

@frano-m frano-m commented Aug 11, 2023

Ticket

Closes clevercanary#899

Reviewers

@NoopDog

Changes

  • Added warning to non "dataset" tabs.

@frano-m frano-m requested a review from NoopDog August 11, 2023 06:06
@github-actions github-actions bot added the canary Done by the Clever Canary team label Aug 11, 2023
Copy link
Collaborator

@NoopDog NoopDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @frano-m thanks!

@NoopDog NoopDog merged commit 0a68ff2 into DataBiosphere:main Aug 11, 2023
@NoopDog NoopDog deleted the fran/899-warning branch August 11, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Done by the Clever Canary team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AnVIL CMG] Show warning on non "dataset" tabs that entities are not listed for "access required" datasets
2 participants