Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bruce/910 fixing error component #3731

Conversation

BruceRodrigues
Copy link
Contributor

@BruceRodrigues BruceRodrigues commented Oct 31, 2023

Ticket

Closes #910

Reviewers

@.

Changes

  • Modified ErrorBoundary to force rerender when path changes

Definition of Done (from ticket)

QA steps (optional)

Known Issues

@github-actions github-actions bot added the canary Done by the Clever Canary team label Oct 31, 2023
@BruceRodrigues
Copy link
Contributor Author

@frano-m @NoopDog to complete this, we need to merge this PR on data-explorer and update the package version here.

@frano-m frano-m closed this Nov 6, 2023
@frano-m frano-m reopened this Nov 6, 2023
Copy link
Contributor

@frano-m frano-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @BruceRodrigues thank you!

@NoopDog
Copy link
Collaborator

NoopDog commented Nov 7, 2023

Sorry @BruceRodrigues can you redo this from DataBiosphere ?

@BruceRodrigues
Copy link
Contributor Author

This PR was moved to this one #3754 created from DataBiosphere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Done by the Clever Canary team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ErrorBoundary component to allow the error to be cleared
3 participants