Jpaten/4076 add list of current and candidate tests #4077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MillenniumFalconMechanic
requested changes
Aug 15, 2024
explorer/e2e/testReadme.md
Outdated
| that Playwright actually runs, most test code is stored in `e2e/testFunctions.ts`. These functions contain the | ||
| code that runs for all tests, except for tests that are not reused between configurations and that only run in one tab. This allows tests to be repeated | ||
| for different tabs in different configurations without reusing code, and means that information that tests | ||
| depend on can be stored in one place to make adjusting tests to changes in user facing content is straightforward. |
There was a problem hiding this comment.
Suggested change
| depend on can be stored in one place to make adjusting tests to changes in user facing content is straightforward. | |
| depend on can be stored in one place to make adjusting tests to changes in user-facing content straightforward. |
explorer/e2e/testReadme.md
Outdated
| code that runs for all tests, except for tests that are not reused between configurations and that only run in one tab. This allows tests to be repeated | ||
| for different tabs in different configurations without reusing code, and means that information that tests | ||
| depend on can be stored in one place to make adjusting tests to changes in user facing content is straightforward. | ||
| Config specific constants used for tests are kept in the `config_name/config_name-tabs.ts`, and use interfaces and |
There was a problem hiding this comment.
Suggested change
| Config specific constants used for tests are kept in the `config_name/config_name-tabs.ts`, and use interfaces and | |
| Config-specific constants used for tests are kept in the `config_name/config_name-tabs.ts`, and use interfaces and |
explorer/e2e/testReadme.md
Outdated
| Config specific constants used for tests are kept in the `config_name/config_name-tabs.ts`, and use interfaces and | ||
| custom types in `testInterfaces.ts`. | ||
|
|
||
| ### Running tests |
There was a problem hiding this comment.
Suggested change
| ### Running tests | |
| ### Running Tests |
explorer/e2e/testReadme.md
Outdated
| and `playwright_anvil-catalog.config.ts`. To run an individual test, add the argument `-g <test_name>`. More information | ||
| about command line options for the test can be found in [Playwright's Documentation](https://playwright.dev/docs/test-cli). | ||
| To debug or write tests, it can be useful to use Playwright's UI mode with `npx playwright test --ui`, which allows you | ||
| to easily run individual tests, and view the actions Playwright takes step by step in and their result. |
There was a problem hiding this comment.
Suggested change
| to easily run individual tests, and view the actions Playwright takes step by step in and their result. | |
| to easily run individual tests, and view the actions Playwright takes step by step and their result. |
explorer/e2e/testReadme.md
Outdated
|
|
||
| #### Running in GitHub | ||
|
|
||
| All tests are run automatically when a pull request is made, using GitHub Actions. These actions create a development build |
There was a problem hiding this comment.
Suggested change
| All tests are run automatically when a pull request is made, using GitHub Actions. These actions create a development build | |
| All tests are run automatically when a pull request is made, using GitHub Actions. These actions create a dev build |
^ Keeps the language consistent with above?
explorer/e2e/testReadme.md
Outdated
| - Check that selecting a filter causes the selected checkbox entries to remain selected across all tabs | ||
| - Currently uses the 4th filter and starts on the "files" tab | ||
| - Check that the counts next to the filter checkbox match the number of entries once the filter is selected | ||
| - Checks an arbitrary list of 6 filters on the datasets and activities tab |
There was a problem hiding this comment.
Suggested change
| - Checks an arbitrary list of 6 filters on the datasets and activities tab | |
| - Checks an arbitrary list of six filters on the datasets and activities tab |
explorer/e2e/testReadme.md
Outdated
| - Currently uses the 4th filter and starts on the "files" tab | ||
| - Check that the counts next to the filter checkbox match the number of entries once the filter is selected | ||
| - Checks an arbitrary list of 6 filters on the datasets and activities tab | ||
| - Check that the blue filter buttons appear with the correct text when the filter is selected, and that they cause the filter to become deselected when clicked |
There was a problem hiding this comment.
Suggested change
| - Check that the blue filter buttons appear with the correct text when the filter is selected, and that they cause the filter to become deselected when clicked | |
| - Check that the blue filter tags appear with the correct text when the filter is selected, and that they cause the filter to become deselected when clicked |
explorer/e2e/testReadme.md
Outdated
| - Check that the counts next to the filter checkbox match the number of entries once the filter is selected | ||
| - Checks an arbitrary list of 6 filters on the datasets and activities tab | ||
| - Check that the blue filter buttons appear with the correct text when the filter is selected, and that they cause the filter to become deselected when clicked | ||
| - Checks an arbitrary list of 3 filters on the "files" and "biosamples" tabs |
There was a problem hiding this comment.
Suggested change
| - Checks an arbitrary list of 3 filters on the "files" and "biosamples" tabs | |
| - Checks an arbitrary list of three filters on the "files" and "biosamples" tabs |
explorer/e2e/testReadme.md
Outdated
| - Check that the blue filter buttons appear with the correct text when the filter is selected, and that they cause the filter to become deselected when clicked | ||
| - Checks an arbitrary list of 3 filters on the "files" and "biosamples" tabs | ||
| - Check that the clear all button deselects all filters, after an arbitrary list is selected | ||
| - Uses an arbitrary list of 3 filters and runs on the "files tab" |
There was a problem hiding this comment.
Suggested change
| - Uses an arbitrary list of 3 filters and runs on the "files tab" | |
| - Uses an arbitrary list of three filters and runs on the "files tab" |
explorer/e2e/testReadme.md
Outdated
| - Check that paginating forward on the donors tab keeps the currently displayed page number correct, and that on the last page the back button is enabled and the front page is enabled | ||
| - Uses the "Donors" tab only | ||
| - NOTE: this test may be problematic because it assumes there is relatively short number of pages on the "Donors" tab. This could potentially be resolved by adding filters or by limiting the number of tests run | ||
| - Check that paginating forwards by up to 5 pages changes the content on the first row of the table, and that paginating backwards causes that text to remain the same |
There was a problem hiding this comment.
Suggested change
| - Check that paginating forwards by up to 5 pages changes the content on the first row of the table, and that paginating backwards causes that text to remain the same | |
| - Check that paginating forwards by up to five pages changes the content on the first row of the table, and that paginating backwards causes that text to remain the same |
jpaten
force-pushed
the
jpaten/4076-add-list-of-current-and-candidate-tests
branch
from
fd21c57 to
bb86679
Compare
jpaten
force-pushed
the
jpaten/4076-add-list-of-current-and-candidate-tests
branch
from
bb86679 to
587cfc2
Compare
MillenniumFalconMechanic
approved these changes
Aug 22, 2024
jpaten
force-pushed
the
jpaten/4076-add-list-of-current-and-candidate-tests
branch
from
587cfc2 to
7657375
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #4076 .
Reviewers
@MillenniumFalconMechanic .
Changes
Note: This PR should not be merged before #4071