Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add percent change to analytics package #4335

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

jpaten
Copy link
Contributor

@jpaten jpaten commented Jan 14, 2025

Ticket

Closes #4339.

Reviewers

@hunterckx .
@NoopDog

Changes

  • BREAKING: renamed get_outbound_sheets to get_outbound_links (the former name was a typo)
  • BREAKING: renamed options to sheet_formatting_options in get_outbound_links's parameters
  • Added optional column_formatting_options to get_outbound_links to allow for formatting percent change reports
  • Added function in sheets_elements to get percent change for outbound link reports
  • See example sheet for results

@jpaten jpaten requested review from NoopDog and hunterckx January 14, 2025 02:27
@jpaten jpaten linked an issue Jan 14, 2025 that may be closed by this pull request
@github-actions github-actions bot added the canary Done by the Clever Canary team label Jan 14, 2025
@jpaten jpaten changed the title Jonah/4331 add percent change to analytics package feat: add percent change to analytics package Jan 14, 2025
@jpaten jpaten force-pushed the jonah/4331-add-percent-change-to-analytics-package branch from 57f4441 to d544db5 Compare January 17, 2025 17:38
@hunterckx hunterckx merged commit eef1cee into main Jan 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Done by the Clever Canary team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add percent change to analytics package
3 participants