-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AN-296 Upgrade Werkzeug to 3.0.6 #796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
High time to replace Job Manager so we don't do this again in two years.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks for figuring this out 😱 I only have a couple of minor comments, lmk what you think.
from ..__main__ import loadCapabilities | ||
from ..models.capabilities_response import CapabilitiesResponse | ||
from . import BaseTestCase | ||
from . import create_app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, and not necessarily something to tackle in this PR as it seemed to have n=been the prior behavior, but using relative paths to import modules are not very robust, and setting up each init.py file so that we can import like from test import create_app
would be a lot nicer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed... I'm not going to do that in this PR, I think there's enough churn already, but good to keep in mind next time we're in here.
This upgrade ended up being, uh, nontrivial.
flask_testing
, which seems to be abandonware, so updated tests to use plainunittest
instead./jobs/operationDetails
before/jobs/{id}
), otherwise parameter parsing failed.