merge main, address comments

DataBiosphere · Jan 23, 2025 · 1e28f49 · 1e28f49
1 parent ed39558
commit 1e28f49
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/docs/generated/UNDERLAY_CONFIG.md b/docs/generated/UNDERLAY_CONFIG.md
@@ -143,7 +143,7 @@ List of attributes grouped together for search optimization.
 ### SZAttributeSearch.includeEntityMainColumns
 **optional** boolean
 
-True if all columns from the EntityMain table should be included in this table. 
+Whether all columns in the entity main table should also be included in this search table. Improves performance if other attributes are also fetched when performing this search by attributes.
 
 *Default value:* `false`
 

diff --git a/underlay/src/main/java/bio/terra/tanagra/api/filter/EntityFilter.java b/underlay/src/main/java/bio/terra/tanagra/api/filter/EntityFilter.java
@@ -32,8 +32,7 @@ public Entity getEntity() {
   }
 
   public List<Attribute> getFilterAttributes() {
-    logger.debug(
-        "FilterAttributes not supported/implemented for " + this.getClass().getSimpleName());
+    // not supported or not implemented
     return List.of();
   }
 

diff --git a/underlay/src/main/java/bio/terra/tanagra/underlay/serialization/SZAttributeSearch.java b/underlay/src/main/java/bio/terra/tanagra/underlay/serialization/SZAttributeSearch.java
@@ -28,7 +28,10 @@ public class SZAttributeSearch {
 
   @AnnotatedField(
       name = "SZAttributeSearch.includeEntityMainColumns",
-      markdown = "True if all columns from the EntityMain table should be included in this table. ",
+      markdown =
+          "Whether all columns in the entity main table should also be included "
+              + "in this search table. Improves performance if other attributes are also fetched "
+              + "when performing this search by attributes.",
       optional = true,
       defaultValue = "false")
   public boolean includeEntityMainColumns;