Fix several small issues on the cohort overiew #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tjennison-work
commented
Jan 13, 2025
tjennison-work
commented
- Swap cohort criteria to left side. Make the visualizations secondary until they're interactive enough to be the primary editing surface.
- Make the cohort criteria wider. Almost all criteria were too long to be effectively displayed.
- Remove interactivity from the background of criteria so only the title selects/unselects. It was causing a number of corner cases where criteria controls behaved unpredictably and some were difficult to solve due to the way JS handles mouse events. This removes the need to squash mouse events throughout the code. Show title hover underlining on selected criteria as well to make it clear it's still clickable.
- Refactor uncontained select style to a shared file.
- Fix rare issue were criteria buttons could spill onto a second row.
- Add a drop down to select which visualizations are displayed. Add optional config to limit the default set displayed.
tjennison-work
force-pushed
the
tj-cohort-ui
branch
2 times, most recently
from
0364832 to
74d803c
Compare
dexamundsen
approved these changes
Jan 14, 2025
| )} | ||
| </GridBox> | ||
| </GridLayout> | ||
| </Paper> | ||
| ); | ||
| } | ||
|
|
||
| // TODO(tjennison): Store the selected visualizations in local storage per |
There was a problem hiding this comment.
I'm not a fan of creating tickets for TODOs unless they're bugs or part of ongoing work. Too often they just end up cluttering up the backlog because plans change and then you have to actually change the code to get rid of them.
* Swap cohort criteria to left side. Make the visualizations secondary until they're interactive enough to be the primary editing surface. * Make the cohort criteria wider. Almost all criteria were too long to be effectively displayed. * Remove interactivity from the background of criteria so only the title selects/unselects. It was causing a number of corner cases where criteria controls behaved unpredictably and some were difficult to solve due to the way JS handles mouse events. This removes the need to squash mouse events throughout the code. Show title hover underlining on selected criteria as well to make it clear it's still clickable. * Refactor uncontained select style to a shared file. * Fix rare issue were criteria buttons could spill onto a second row. * Add a drop down to select which visualizations are displayed. Add optional config to limit the default set displayed.
tjennison-work
force-pushed
the
tj-cohort-ui
branch
from
74d803c to
0e86a62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.