Add rename group option for cohorts #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolbeew
force-pushed
the
dolbeew/DT-580
branch
from
76dc021 to
b7f02e3
Compare
ui/src/overview.tsx
Outdated
| @@ -321,6 +323,9 @@ function ParticipantsGroupSection(props: { | |||
| }} | |||
| > | |||
| <GridLayout rows height="auto"> | |||
| {!!props.groupSection.name && ( | |||
| <Typography sx={{ p: 1 }}>{props.groupSection.name}</Typography> | |||
There was a problem hiding this comment.
Use variant="body1em" so it stands out a bit more.
ui/src/overview.tsx
Outdated
| @@ -321,6 +323,9 @@ function ParticipantsGroupSection(props: { | |||
| }} | |||
| > | |||
| <GridLayout rows height="auto"> | |||
| {!!props.groupSection.name && ( | |||
There was a problem hiding this comment.
Use the sectionName helper in cohort.ts and always display the name. Also move it into the grey above the dropdowns and horizontally align it with them.
There was a problem hiding this comment.
Nice, didn't see sectionName first time around. I've updated the screenshot in the description after addressing the comments.
ui/src/overview.tsx
Outdated
| @@ -569,6 +574,24 @@ function ParticipantsGroupSection(props: { | |||
| boxShadow: (theme) => `inset 0 1px 0 ${theme.palette.divider}`, | |||
| }} | |||
| > | |||
| <Button | |||
There was a problem hiding this comment.
Make this an IconButton and put it beside the section name like the cohort rename button.
dolbeew
force-pushed
the
dolbeew/DT-580
branch
from
b7f02e3 to
b0c76ee
Compare
tjennison-work
approved these changes
Jan 17, 2025
ui/src/overview.tsx
Outdated
| cols | ||
| sx={{ | ||
| p: 2, | ||
| paddingBottom: 0, |
There was a problem hiding this comment.
I'd use px: 2, pt:2 instead.
| @@ -321,6 +328,35 @@ function ParticipantsGroupSection(props: { | |||
| }} | |||
| > | |||
| <GridLayout rows height="auto"> | |||
| <GridLayout | |||
| cols | |||
There was a problem hiding this comment.
Add rowAlign="middle" to line up the button better with the text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Rename Groupoption to each cohort group section in cohort builder.First group in screenshot above has a custom name, second group has the default group name.