Add pip install tests to terra-jupyter-python. #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be sure to remove this pin when tensorflow is next upgraded.
Do this by installing pytest in the USER path instead of PIP_TARGET.
The prior ones work correctly on Terra, but not here in the context of nbconvert.
|
Note that the test failure in terra-jupyter-base has nothing to do with this change - I only added a comment to the Dockerfile. The test failures there will be addressed with the upgrade to tensorflow 2.7 in #281 |
Qi77Qi
approved these changes
Dec 21, 2021
deflaux
commented
Jan 10, 2022
| "source": [ | ||
| "output = !pip3 show docstring-parser\n", | ||
| "print(output) # Should show that it is now installed!\n", | ||
| "# TODO uncomment this test after https://github.com/DataBiosphere/terra-docker/issues/285\n", |
There was a problem hiding this comment.
Uncomment this after #285 to re-enable the failing test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new tests to demonstrate:
pip installwhen building library from source forterra-jupyter-gatkimg #285 is fixed, the final assertion is commented out for nowAlso fixes some test breakage: