Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE-196] Refactor feedbackURL and articleURL in feature preview logic #5224

Merged
merged 5 commits into from
Jan 27, 2025
Merged

[CORE-196] Refactor feedbackURL and articleURL in feature preview logic #5224

merged 5 commits into from
Jan 27, 2025

Conversation

samanehsan
Copy link
Contributor

@samanehsan samanehsan commented Jan 21, 2025 •
edited
Loading

Jira Ticket: https://broadworkbench.atlassian.net/browse/CORE-257

Summary of changes:

What

  • Remove articleUrl variable (re-use feedbackUrl instead)
  • Change text for all features to say "Learn more and provide feedback"

Why

  • We want to stop using emails for collecting feedback and switch over to support articles so we do not need two separate fields.

Testing strategy

  • Ran the Terra-UI locally
Screenshot 2025-01-27 at 3 02 25 PM

@samanehsan samanehsan marked this pull request as ready for review January 27, 2025 17:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@samanehsan samanehsan added this pull request to the merge queue Jan 27, 2025
Merged via the queue into dev with commit 84c6873 Jan 27, 2025
11 checks passed
@samanehsan samanehsan deleted the se/CORE-196-fix-feature-preview-feedback-urls branch January 27, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinmarete kevinmarete kevinmarete approved these changes

@calypsomatic calypsomatic calypsomatic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samanehsan @calypsomatic @kevinmarete @broadbot