-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE-268] Improve Consolidated Spend Report error handling #5232
Conversation
@@ -102,6 +102,8 @@ export interface WorkspaceSpendData { | |||
credits: string; | |||
currency: string; | |||
googleProjectId: string; | |||
endTime?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had included endTime
and startTime
in my test objects because that's what the real-life WorkspaceSpendData
responses included, and it broke the build. It seems like it makes sense to match the actual object, so I've added these fields in as optional
Quality Gate passedIssues Measures |
Jira Ticket: https://broadworkbench.atlassian.net/browse/CORE-268
Summary of changes:
What
This PR:
Before:
errornotcaught.mov
After:
errorcaught.mov
Why
Testing strategy