Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE-272] Fix Missing Prompt for Billing Workspace in Requester Pays Workspaces Analysis Tab #5238

Merged
merged 5 commits into from
Jan 30, 2025
Merged

[CORE-272] Fix Missing Prompt for Billing Workspace in Requester Pays Workspaces Analysis Tab #5238

merged 5 commits into from
Jan 30, 2025
+103 −5

Conversation

kevinmarete
Copy link
Contributor

Jira Ticket: https://broadworkbench.atlassian.net/browse/CORE-272

What

  • This PR fixes an issue where users aren't prompted to select a billing workspace when accessing analyses in requester pays-enabled workspaces, leading to a 400 error.

Why

  • Currently, users get an error instead of a prompt to enter a workspace for billing. This fix ensures users are prompted correctly, preventing the error and improving the user experience when accessing analyses.

Testing strategy

  • Manual Testing: Access requester pays-enabled workspace, went to the Analysis tab, and ensured prompt is displayed
  • Unit Testing: Added unit tests to ensure the error is thrown and handled in the Analysis tab.
  • Regression Testing: Ensured other workspace sections (e.g., file viewer) still work as expected.

Before
Before

After
After

@kevinmarete kevinmarete requested a review from a team January 30, 2025 02:16
@kevinmarete kevinmarete self-assigned this Jan 30, 2025
@kevinmarete kevinmarete requested review from dvoet, samanehsan and a team and removed request for a team, dvoet and samanehsan January 30, 2025 02:16
@kevinmarete kevinmarete requested a review from a team as a code owner January 30, 2025 02:16
@kevinmarete kevinmarete requested review from calypsomatic and marctalbott and removed request for a team January 30, 2025 02:16
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
60.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kevinmarete kevinmarete added this pull request to the merge queue Jan 30, 2025
Merged via the queue into dev with commit be9e057 Jan 30, 2025
11 checks passed
@kevinmarete kevinmarete deleted the km_CORE-272_requester_pays_analysis_tab branch January 30, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marctalbott marctalbott marctalbott approved these changes

@LizBaldo LizBaldo LizBaldo approved these changes

@calypsomatic calypsomatic calypsomatic approved these changes

Assignees

@kevinmarete kevinmarete

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kevinmarete @calypsomatic @LizBaldo @marctalbott @broadbot