Update published contigs #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, contigs undergoing only one filter were published
mberacochea
approved these changes
Dec 4, 2024
subworkflows/local/assembly_qc.nf
Outdated
| ) | ||
|
|
||
| emit: | ||
| filtered_contigs = filtered_contigs | ||
| filtered_contigs = cleaned_contigs |
There was a problem hiding this comment.
We should also rename the output to avoid having to remember this name mapping outside the module
There was a problem hiding this comment.
To which output are you referring to, the one from this subwf or the one for published contigs? @mberacochea
There was a problem hiding this comment.
This one, in the emit:
filtered_contigs = cleaned_contigs
should be
cleaned_contigs = cleaned_contigs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to be put in production to solve a small bug. Previously, contigs filtered by human were published. We want those filtered by host too.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).README.mdis updated (including new tool citations and authors/contributors).