Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update published contigs #25

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Update published contigs #25

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a912f6
Update published contigs
Ge94 Dec 3, 2024
a84b222
Simplified contigs to publish
Ge94 Dec 3, 2024
9bbed3e
Refactor of variables
Ge94 Dec 4, 2024
e831147
replaced published_contigs variable
Ge94 Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions subworkflows/local/assembly_qc.nf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ workflow ASSEMBLY_QC {

ch_versions = ch_versions.mix(SEQKIT_SEQ.out.versions)

filtered_contigs = SEQKIT_SEQ.out.fastx
cleaned_contigs = SEQKIT_SEQ.out.fastx

if ( params.remove_human_phix ) {

Expand All @@ -52,10 +52,10 @@ workflow ASSEMBLY_QC {
ch_versions = ch_versions.mix(BLAST_BLASTN_HUMAN_PHIX.out.versions.first())

SEQKIT_GREP_HUMAN_PHIX(
filtered_contigs.join( BLAST_BLASTN_HUMAN_PHIX.out.txt )
cleaned_contigs.join( BLAST_BLASTN_HUMAN_PHIX.out.txt )
)

filtered_contigs = SEQKIT_GREP_HUMAN_PHIX.out.filter
cleaned_contigs = SEQKIT_GREP_HUMAN_PHIX.out.filter

ch_versions = ch_versions.mix(SEQKIT_GREP_HUMAN_PHIX.out.versions)
}
Expand All @@ -68,14 +68,14 @@ workflow ASSEMBLY_QC {
}

BLAST_BLASTN_HOST(
filtered_contigs,
cleaned_contigs,
ch_blast_host_refs
)

ch_versions = ch_versions.mix(BLAST_BLASTN_HOST.out.versions.first())

SEQKIT_GREP_HOST(
filtered_contigs.join( BLAST_BLASTN_HOST.out.txt )
cleaned_contigs.join( BLAST_BLASTN_HOST.out.txt )
)

cleaned_contigs = SEQKIT_GREP_HOST.out.filter
Expand All @@ -84,10 +84,10 @@ workflow ASSEMBLY_QC {
}

PUBLISH_CLEANED_CONTIGS(
filtered_contigs
cleaned_contigs
)

emit:
filtered_contigs = filtered_contigs
filtered_contigs = cleaned_contigs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also rename the output to avoid having to remember this name mapping outside the module

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To which output are you referring to, the one from this subwf or the one for published contigs? @mberacochea

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one, in the emit:

filtered_contigs = cleaned_contigs

should be

cleaned_contigs = cleaned_contigs

versions = ch_versions
}
Loading