Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement thermo_water_update scheme (non-portable wrapper to cam_thermo_water_update) #178

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

jimmielin
Copy link
Member

@jimmielin jimmielin commented Dec 12, 2024

Originator(s): @jimmielin

Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number):

Closes #177, implementing thermo_water_update scheme to call cam_thermo_water_update.

Describe any changes made to the namelist: N/A

List all files eliminated and why: N/A

List all files added and what they do:

Implement thermo_water_update scheme
A schemes/thermo_water_update/thermo_water_update.F90
A schemes/thermo_water_update/thermo_water_update.meta

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

Include thermo_water_update scheme in CAM7 suite
M suites/suite_cam7.xml

List any test failures:

Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? Yes

@jimmielin jimmielin added the enhancement New feature or request label Dec 12, 2024
@jimmielin jimmielin self-assigned this Dec 12, 2024
@jimmielin jimmielin marked this pull request as draft December 12, 2024 23:17
@jimmielin
Copy link
Member Author

jimmielin commented Dec 12, 2024

Marking as draft until ESCOMP/CAM-SIMA#316 is merged and CAM7 test failure is resolved (ESCOMP/CAM-SIMA#335) so this "scheme" can be fully tested.

@jimmielin jimmielin requested a review from nusbaume January 9, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant