Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Probe module waits for ready signal in another thread to avoid hangs #108

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

valentin-dimov
Copy link
Contributor

@valentin-dimov valentin-dimov commented Dec 4, 2023

NOTE: This may not be a full fix, as asyncio objects technically aren't thread-safe, but it works well enough for now.

… to avoid hangs

NOTE: This isn't a full fix, as asyncio objects technically aren't thread-safe, but it works well enough for now.

Signed-off-by: Valentin Dimov <[email protected]>
Copy link
Contributor

@klemmpnx klemmpnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@valentin-dimov valentin-dimov merged commit f673ca4 into main Dec 4, 2023
6 checks passed
@valentin-dimov valentin-dimov deleted the vd-fix-probe-module-hangs branch December 4, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants