Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Probe module waits for ready signal in another thread to avoid hangs #108

Merged
merged 2 commits into from
Dec 4, 2023
Merged

fix: Probe module waits for ready signal in another thread to avoid hangs #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
920e67c
fix: Probe module splits waiting for ready signal into another thread…
valentin-dimov Dec 4, 2023
b8e3449
refactor: remove unnecessary lambda
valentin-dimov Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion everest-testing/src/everest/testing/core_utils/probe_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,4 +116,4 @@ async def wait_to_be_ready(self, timeout=3):
if not self._started:
raise RuntimeError("Called wait_to_be_ready(), but probe module has not been started yet! "
"Please use start() to start the module first.")
await asyncio.wait_for(self._ready_event.wait(), timeout)
await asyncio.wait_for(asyncio.to_thread(self._ready_event.wait), timeout)