-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor README.md for PGXN #168
base: master
Are you sure you want to change the base?
Conversation
Add separate `INSTALL.md`. Other changes in `README.md` for unifying with https://github.com/pgspider FDW documentation template and by https://github.com/ibarwick/firebird_fdw/blob/master/README.md example of advanced FDW documentation.
Thanks, @mkgrgis for patch. I did more changes like fixing spelling mistakes, deleting duplicate code, indentation, etc. Find revised patch. Please find difference between patch provided by you and me. If you're agree with the changes then post this patch or point out the changes you are NOT agree. Thanks. |
Thanks for the patch, @vaibhavdalvi93 , I am studying the changes. |
@vaibhavdalvi93, SQL indent in Examples in case of Note: I have viewed your patch during mkgrgis@92280f5 |
@mkgrgis , Thanks for your comment on v2 patch provided by me.
As there are quite more changes I have done in my patch, I am not finding myself comfortable pointing or commenting out each change directly on files.
Thanks. |
No problem, @vaibhavdalvi93 ! Unfortunately in your previous message "patch" is not URL for downloading. If you are about this version https://github.com/EnterpriseDB/mongo_fdw/files/12802661/v2-Refactor-README.md-for-PGXN.txt , I have no other comments. You can discuss this patch with commiter. Anyway I can open new PR after this if there will be some new |
Okay. Thank you for your response. I will take it further to the commiter. Thanks, again. |
The main changes include moving the installation steps to the newly created INSTALL.md file. Other changes in README.md are for unifying it with FDW documentation template. Reported on GitHub through issue #168 by mkgrgis (Михаил). FDW-665, initial patch by mkgrgis, further revised and improved by Vaibhav Dalvi.
Thanks, @vaibhavdalvi93! Could you please begin 2nd round of review? I have seen small differences between our branches and propose a changes. |
Add separate
INSTALL.md
.Other changes in
README.md
for unifying with https://github.com/pgspider FDW documentation template and by https://github.com/ibarwick/firebird_fdw/blob/master/README.md example of advanced FDW documentation.